Add support for editing a space view's space origin #4848
Conversation
|
I expect to be able to arrow down to select one of the suggestions. Having to click on it feels broken. |
|
I find this interaction really surprising. If I click on an editable field I expect to be able to edit it, not that it will be a link. We should remove the edit button and make it behave more like an editable field. The design should at the same time make it clear when other elements are in fact links and if that isn't clear then we need to address that instead 
|
|
I'm noticing a problematic interaction with heuristics we probably need to figure out. In the SFM example, if I click the original space-view |
We probably shouldn't be adding new views once the user has modified the blueprint. Once they have, we could consider highlighting the plus button and suggesting the top three views that would be added if we were to reset the blueprint |
Is that blocking for this PR? |
# Conflicts: # crates/re_viewer/src/ui/selection_panel.rs
| if entered_editing { | ||
| output.response.request_focus(); | ||
| let min = egui::text::CCursor::new(0); | ||
| let max = egui::text::CCursor::new(space_origin_string.len()); | ||
| let new_range = egui::text::CCursorRange::two(min, max); | ||
| output.state.cursor.set_char_range(Some(new_range)); | ||
| output.state.store(ui.ctx(), output.response.id); | ||
| } |
There was a problem hiding this comment.
@emilk I have an problem with this code. It should select all the text, but if the click happens on the text, then it selects only all the way to where the mouse cursor is. I can't make sense of that behaviour. Any idea what's going on?
There was a problem hiding this comment.
issue with repro here: emilk/egui#3883
What
This PR adds the possibility to edit a space view's space origin.
Note:This PR is affected by the following issue:
TextCursorState.set_char_range()interacts wrongly with user click emilk/egui#3883TODO:
space_origin_edit.mp4
Follow-up issues:
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io