Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an heuristic to list all entity sub-trees with content compatible with a given space view class #4895

Open
abey79 opened this issue Jan 23, 2024 · 1 comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🚜 refactor Change the code, not the functionality
Milestone

Comments

@abey79
Copy link
Member

abey79 commented Jan 23, 2024

In order to propose meaningful entity paths, #4848 made use of all_possible_space_views(), which is totally overkill for the purpose. Ideally, there would be a simpler API to list all possible entity sub-trees which contain some content that can be visualised by a given space view class.

@abey79 abey79 added 😤 annoying Something in the UI / SDK is annoying to use 🚜 refactor Change the code, not the functionality labels Jan 23, 2024
abey79 added a commit that referenced this issue Jan 23, 2024
@Wumpf Wumpf added this to the Triage milestone Jan 29, 2024
@Wumpf
Copy link
Member

Wumpf commented Jan 29, 2024

FYI: In an upcoming pr this changes to a filter based on default_created_space_views which is a smaller set but similarly problematic. In fact it's a much slower operation (but due to recent changes decently fast so that we don't mind running it again while this property is edited)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

No branches or pull requests

2 participants