Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto-completion when editing a space origin #4849

Open
abey79 opened this issue Jan 17, 2024 · 0 comments
Open

Implement auto-completion when editing a space origin #4849

abey79 opened this issue Jan 17, 2024 · 0 comments
Labels
ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Jan 17, 2024

#4848 introduced the ability to edit space origin for space views with a popup menu displaying suggestions. It would be nice to also have the ability to "tab-autocomplete" within the text edit.

This should be achievable as follows:

  • use a custom Layouter for the text edit, where the autocomplete suggestion would be appended (with subdued styling) to the text actually entered by the user
  • use lock_focus(true) to avoid defocusing the text edit with Tab (this entered a \t character instead)
  • perform the autocomplete when \t is detected
@abey79 abey79 added the ui concerns graphical user interface label Jan 17, 2024
abey79 added a commit that referenced this issue Jan 24, 2024
### What

This PR adds the possibility to edit a space view's space origin.

**Note**:This PR is affected by the following issue:
- emilk/egui#3883

TODO:
- [x] Are we happy with the general behaviour of this thing?
- [x] Should this be feature gated?


https://github.com/rerun-io/rerun/assets/49431240/37571532-0326-4e43-98ee-8d0e537d9235

Follow-up issues:
- #4849

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4848/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4848/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4848/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4848)
- [Docs
preview](https://rerun.io/preview/307d7c3dc6416fde83960c1c6dabda94f26a0425/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/307d7c3dc6416fde83960c1c6dabda94f26a0425/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

1 participant