Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visiblity toggles for time series not working #2444

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 15, 2023

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself labels Jun 15, 2023
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tested with a few different examples

@Wumpf Wumpf merged commit 1921c04 into main Jun 15, 2023
@Wumpf Wumpf deleted the andreas/fix-visibility-toggle-time-series branch June 15, 2023 13:50
Wumpf added a commit that referenced this pull request Jun 15, 2023
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

Fixes #2415
* #2415

* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2444

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/76a741b/docs
Examples preview: https://rerun.io/preview/76a741b/examples
<!-- pr-link-docs:end -->
@Wumpf Wumpf mentioned this pull request Jun 16, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visibility toggle for time series does not work
2 participants