Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visibility toggle for time series does not work #2415

Closed
Polymere opened this issue Jun 13, 2023 · 1 comment · Fixed by #2444
Closed

visibility toggle for time series does not work #2415

Polymere opened this issue Jun 13, 2023 · 1 comment · Fixed by #2444
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself

Comments

@Polymere
Copy link

Describe the bug
The visibility toggle in the viewer's UI has no effect for the scalar logs / time series
no_toggle_scalar

To Reproduce
Steps to reproduce the behavior:

  1. Log time series data to a viewer
  2. Click on the visibility toggle to try and hide an entry
  3. Line plot is still visible 😢

Expected behavior

Time series plot would be hidden / shown when changing the visibility toggle

Desktop (please complete the following information):

  • OS: Ubuntu 22.04

Rerun version
rerun_py 0.5.1 [rustc 1.67.1 (d5a82bbd2 2023-02-07), LLVM 15.0.6] x86_64-unknown-linux-gnu hotfix-0.5.1 968bf73, built 2023-05-02T21:13:39Z
@Polymere Polymere added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Jun 13, 2023
@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 😤 annoying Something in the UI / SDK is annoying to use and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jun 13, 2023
@emilk emilk added the 🏎️ Quick Issue Can be fixed in a few hours or less label Jun 14, 2023
@bkolligs
Copy link

I'm seeing this as well

@Wumpf Wumpf mentioned this issue Jun 15, 2023
Merged
1 task
@Wumpf Wumpf closed this as completed in 1921c04 Jun 15, 2023
Wumpf added a commit that referenced this issue Jun 15, 2023
@Wumpf
Fix visiblity toggles for time series not working (#2444)
1c95e21 
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

Fixes #2415
* #2415

* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2444

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/76a741b/docs
Examples preview: https://rerun.io/preview/76a741b/examples
<!-- pr-link-docs:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix visiblity toggles for time series not working rerun-io/rerun
4 participants
@emilk @Wumpf @bkolligs @Polymere