Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visiblity toggles for time series not working #2444

Merged
merged 3 commits into from
Jun 15, 2023
+38 −34
Merged

Fix visiblity toggles for time series not working #2444

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f83b16
Fix visiblity toggles for time series not working
Wumpf Jun 15, 2023
ef58408
add comment to warn that entity_paths contains invisible objects
Wumpf Jun 15, 2023
76a741b
make SceneQuery::entity_paths private
Wumpf Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions crates/re_space_view_time_series/src/scene_part.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,7 @@ impl SceneTimeSeries {

let store = &ctx.store_db.entity_db.data_store;

for entity_path in query.entity_paths {
let ent_path = entity_path;

for (ent_path, _ent_props) in query.iter_entities() {
let mut points = Vec::new();
let annotations = self.annotation_map.find(ent_path);
let annotation_info = annotations.class_description(None).annotation_info();
Expand Down Expand Up @@ -167,7 +165,7 @@ impl SceneTimeSeries {
(points.iter().all(|p| p.attrs.label.as_ref() == Some(label)))
.then(|| label.clone())
};
let line_label = same_label(&points).unwrap_or_else(|| entity_path.to_string());
let line_label = same_label(&points).unwrap_or_else(|| ent_path.to_string());

self.add_line_segments(&line_label, points);
}
Expand Down
2 changes: 2 additions & 0 deletions crates/re_viewer_context/src/space_view/scene_query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ pub struct SceneQuery<'s> {
pub space_origin: &'s EntityPath,

/// All queried entities.
///
/// Contains also invisible objects, use `iter_entities` to iterate over visible ones.
pub entity_paths: &'s IntSet<EntityPath>,
Wumpf marked this conversation as resolved.
Show resolved Hide resolved

/// The timeline we're on.
Expand Down