Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re_sdk: fix cranky #1447

Closed
wants to merge 2 commits into from
Closed

re_sdk: fix cranky #1447

wants to merge 2 commits into from

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 28, 2023

Relates to #1446, why doesn't the ci catch that?

@teh-cmc teh-cmc added the 😤 annoying Something in the UI / SDK is annoying to use label Feb 28, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented Feb 28, 2023 •
edited
Loading

I'll let the CI go green, then revert, see what happens...

Run 1: green
Revert: green again 😬
Run 2: todo

@teh-cmc
Revert "pass cranky"
4bba842 
This reverts commit ea6c30a.
@emilk
Copy link
Member

emilk commented Mar 1, 2023 •
edited
Loading

Related?

@emilk emilk marked this pull request as draft March 1, 2023 14:55
@teh-cmc teh-cmc mentioned this pull request Mar 1, 2023
Merged
2 tasks
@jleibs jleibs force-pushed the cmc/cranky_re_sdk branch from 07e7f83 to 4bba842 Compare March 3, 2023 19:47
@emilk emilk mentioned this pull request Mar 21, 2023
Merged
1 task
@emilk
Copy link
Member

emilk commented Mar 21, 2023

I figured this out in #1628 - On CI we run 1.67.0 but locally we are on 1.67.1, and apparently clippy::uninlined_format_args changed behavior in that patch release 🤦

@emilk
Copy link
Member

emilk commented Mar 21, 2023

Closed by #1447

@emilk emilk closed this Mar 21, 2023
This was referenced Mar 21, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @emilk