Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run cranky for wasm32 #317

Closed
wants to merge 1 commit into from
Closed

CI: run cranky for wasm32 #317

wants to merge 1 commit into from

Conversation

emilk
Copy link
Member

@emilk emilk commented Nov 21, 2022

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk emilk force-pushed the emilk/ci-cranky-wasm32 branch from bff0c72 to e066ef2 Compare November 21, 2022 10:07
@emilk emilk force-pushed the emilk/ci-cranky-wasm32 branch from e066ef2 to 1d4ba16 Compare November 21, 2022 10:26
@emilk
Copy link
Member Author

emilk commented Nov 21, 2022

I don't understand why this is green. Locally on this branch:

> cargo cranky -p re_viewer --target wasm32-unknown-unknown --all-features -- -D warnings
…
error: the borrowed expression implements the required traits
  --> crates/re_renderer/src/workspace_shaders.rs:16:24
   |
16 |         fs.create_file(&virtpath, include_str!("../shader/composite.wgsl").into())
   |                        ^^^^^^^^^ help: change this to: `virtpath`
   |
   = note: `-D clippy::needless-borrow` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

@emilk
Copy link
Member Author

emilk commented Mar 21, 2023

Closed by #1447

@emilk emilk closed this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant