Fix re_renderer file watcher watching the same file several times #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
teh-cmc
approved these changes
Mar 1, 2023
| @@ -25,7 +25,7 @@ impl FileWriter { | |||
|
|
|||
| re_log::debug!("Saving file to {path:?}…"); | |||
|
|
|||
| let file = std::fs::File::create(&path).with_context(|| format!("Path: {:?}", path))?; | |||
| let file = std::fs::File::create(&path).with_context(|| format!("Path: {path:?}"))?; | |||
There was a problem hiding this comment.
for some reason clippy started complaining here suddenly
There was a problem hiding this comment.
Well yes it's the famous "oh god I don't want to fix this one otherwise I'll have to justify why it passes the CI" lol #1447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bad in general (we do suprisingly often include the same file several times for good reasons) and application killing if something creates a renderpipeline every frame (which due to pooling should be cheap!).
Via Slack discussion: It could be that this is only an issue on some platforms. On my Mac this was game over but it could be that on Linux where these were tested more intensively this is fine.
Checklist