Run clippy for wasm, with own clippy.toml config file #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
force-pushed
the
emilk/clippy-wasm
branch
from
bccda72 to
6207499
Compare
emilk
force-pushed
the
emilk/clippy-wasm
branch
from
8f1bf57 to
10bfc75
Compare
Small change with how the lint `clippy::uninlined_format_args` acts
jleibs
approved these changes
Mar 21, 2023
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
re_sdk? #1446It is way to easy to accidentally use
std::time::Instant::now, which will break the web-viewer at runtime. With this PR, we now check that we don't use it, or similarly banned method, when compiling for wasm32.I ran into a subtle difference between how clippy acted on
1.67.0and1.67.1. I've now made sure we always use1.67.1both locally and on CI.Checklist