Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected aborts when exiting python after using rr.new_recording #4410

Closed
jleibs opened this issue Nov 30, 2023 · 6 comments
Closed

Unexpected aborts when exiting python after using rr.new_recording #4410

jleibs opened this issue Nov 30, 2023 · 6 comments
Assignees
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🐍 Python API Python logging API

Comments

@jleibs
Copy link
Member

jleibs commented Nov 30, 2023

Both of these cases lead to:

terminate called without an active exception
Aborted (core dumped)
import rerun as rr

for _ in range(3):
    rec = rr.new_recording(application_id="test")
    mem = rec.memory_recording()
    rr.log("test", rr.Points3D([1, 2, 3]), recording=rec.inner)
import rerun as rr

rec = rr.new_recording(application_id="test")
rr.log("test", rr.Points3D([1, 2, 3]), recording=rec.inner)

However, a single memory recording appears to work fine without aborting:

rec = rr.new_recording(application_id="test")
rec.memory_recording()
rr.log("test", rr.Points3D([1, 2, 3]), recording=rec.inner)
@jleibs jleibs added 🪳 bug Something isn't working 🐍 Python API Python logging API labels Nov 30, 2023
@emilk emilk added the 💣 crash crash, deadlock/freeze, do-no-start label Nov 30, 2023
@emilk
Copy link
Member

emilk commented Nov 30, 2023

It's very annoying that we don't get a stacktrace on SIGABRT

abey79 added a commit that referenced this issue Dec 1, 2023
### What

This PR adds the 3 basic benchmarks for Python. One notable different
w.r.t the rust version is that the benchmarks use a single recording,
but create a fresh memory sink for each iteration (the rust version
creates a fresh recording for each iteration as well). This is due to
#4410.

To run:
```
just py-bench
```

**IMPORTANT**: the python version of `many_individual` runs 100k points
instead of 1M for the other benchmarks!

* Part of #4100

On my machine:

<img width="1590" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/99a74354-aa09-4267-a0fa-6587ecd9f8e5">

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4411) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4411)
- [Docs
preview](https://rerun.io/preview/0f8403061c76b2147bebef25cfebd1b0c5e47c73/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/0f8403061c76b2147bebef25cfebd1b0c5e47c73/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@teh-cmc
Copy link
Member

teh-cmc commented Dec 1, 2023

Huh, interestingly both test cases behave properly at first and then get stuck indefinitely on Python 3.8, e.g.:

$ python main.py
DEV ENVIRONMENT DETECTED! Re-importing rerun from: /home/cmc/dev/rerun-io/rerun/rerun_py/rerun_sdk
[2023-12-01T16:21:03Z WARN  re_sdk::log_sink] Dropping data in MemorySink
[2023-12-01T16:21:03Z WARN  re_sdk::log_sink] Dropping data in MemorySink
[2023-12-01T16:21:03Z WARN  re_sdk::log_sink] Dropping data in MemorySink
[2023-12-01T16:21:03Z WARN  re_sdk::log_sink] Dropping data in MemorySink


# stuck, but no crash

^C

I do crash on Python 3.11.

@teh-cmc
Copy link
Member

teh-cmc commented Dec 1, 2023

Backtrace from the core dump:
image

Text version:
#0  0x00007f2c088ac83c in ?? () from /usr/lib/libc.so.6
#1  0x00007f2c0885c668 in raise () from /usr/lib/libc.so.6
#2  0x00007f2c088444b8 in abort () from /usr/lib/libc.so.6
#3  0x00007f2c0549ca6f in __gnu_cxx::__verbose_terminate_handler () at /usr/src/debug/gcc/gcc/libstdc++-v3/libsupc++/vterminate.cc:95
#4  0x00007f2c054b011c in __cxxabiv1::__terminate (handler=<optimized out>) at /usr/src/debug/gcc/gcc/libstdc++-v3/libsupc++/eh_terminate.cc:48
#5  0x00007f2c054b0189 in std::terminate () at /usr/src/debug/gcc/gcc/libstdc++-v3/libsupc++/eh_terminate.cc:58
#6  0x00007f2c054af9cd in __cxxabiv1::__gxx_personality_v0 (version=<optimized out>, actions=10, exception_class=0, ue_header=<optimized out>, context=0x7f2baf3fc180) at /usr/src/debug/gcc/gcc/libstdc++-v3/libsupc++/eh_personality.cc:673
#7  0x00007f2c079bb6f4 in _Unwind_ForcedUnwind_Phase2 (exc=exc@entry=0x7f2baf3fdd30, context=context@entry=0x7f2baf3fc180, frames_p=frames_p@entry=0x7f2baf3fc088) at /usr/src/debug/gcc/gcc/libgcc/unwind.inc:183
#8  0x00007f2c079bbe20 in _Unwind_ForcedUnwind (exc=0x7f2baf3fdd30, stop=0x7f2c088b2fa0, stop_argument=<optimized out>) at /usr/src/debug/gcc/gcc/libgcc/unwind.inc:218
#9  0x00007f2c088b3187 in ?? () from /usr/lib/libc.so.6
#10 0x00007f2c088abc3a in pthread_exit () from /usr/lib/libc.so.6
#11 0x00007f2c08b8a3e2 in PyThread_exit_thread () from /usr/lib/libpython3.11.so.1.0
#12 0x00007f2c08af153d in ?? () from /usr/lib/libpython3.11.so.1.0
#13 0x00007f2c08be0706 in PyEval_RestoreThread () from /usr/lib/libpython3.11.so.1.0
#14 0x00007f2c08cc90fa in PyGILState_Ensure () from /usr/lib/libpython3.11.so.1.0
#15 0x00007f2bb412b8ca in arrow::py::NumPyBuffer::~NumPyBuffer() () from /home/cmc/dev/rerun-io/rerun/venv310/lib/python3.11/site-packages/pyarrow/libarrow_python.so.1000
#16 0x00007f2bb411112e in std::_Sp_counted_ptr_inplace<arrow::ArrayData, std::allocator<arrow::ArrayData>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() () from /home/cmc/dev/rerun-io/rerun/venv310/lib/python3.11/site-packages/pyarrow/libarrow_python.so.1000
#17 0x00007f2bb411108e in std::_Sp_counted_ptr_inplace<arrow::ArrayData, std::allocator<arrow::ArrayData>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() () from /home/cmc/dev/rerun-io/rerun/venv310/lib/python3.11/site-packages/pyarrow/libarrow_python.so.1000
#18 0x00007f2bb0d6f6fa in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() () from /home/cmc/dev/rerun-io/rerun/venv310/lib/python3.11/site-packages/pyarrow/libarrow.so.1000
#19 0x00007f2bb1831fec in arrow::(anonymous namespace)::ReleaseExportedArray(ArrowArray*) () from /home/cmc/dev/rerun-io/rerun/venv310/lib/python3.11/site-packages/pyarrow/libarrow.so.1000
#20 0x00007f2bb63c67e3 in arrow2::ffi::array::{impl#2}::drop (self=0x165a06) at src/ffi/array.rs:59
#21 core::ptr::drop_in_place<arrow2::ffi::generated::ArrowArray> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#22 alloc::sync::Arc<arrow2::ffi::generated::ArrowArray, alloc::alloc::Global>::drop_slow<arrow2::ffi::generated::ArrowArray, alloc::alloc::Global> (self=<optimized out>) at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/alloc/src/sync.rs:1751
#23 0x00007f2bb63c65bc in alloc::sync::{impl#33}::drop<arrow2::ffi::generated::ArrowArray, alloc::alloc::Global> (self=0x165a06) at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/alloc/src/sync.rs:2407
#24 core::ptr::drop_in_place<alloc::sync::Arc<arrow2::ffi::generated::ArrowArray, alloc::alloc::Global>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#25 core::ptr::drop_in_place<arrow2::ffi::array::InternalArrowArray> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#26 core::ptr::drop_in_place<arrow2::buffer::BytesAllocator> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#27 core::ptr::drop_in_place<foreign_vec::Allocation<arrow2::buffer::BytesAllocator>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#28 core::ptr::drop_in_place<foreign_vec::ForeignVec<arrow2::buffer::BytesAllocator, i32>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#29 alloc::sync::Arc<foreign_vec::ForeignVec<arrow2::buffer::BytesAllocator, i32>, alloc::alloc::Global>::drop_slow<foreign_vec::ForeignVec<arrow2::buffer::BytesAllocator, i32>, alloc::alloc::Global> (self=<optimized out>) at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/alloc/src/sync.rs:1751
#30 0x00007f2bb63fb70c in alloc::sync::{impl#33}::drop<foreign_vec::ForeignVec<arrow2::buffer::BytesAllocator, f32>, alloc::alloc::Global> (self=0x165a06) at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/alloc/src/sync.rs:2407
#31 core::ptr::drop_in_place<alloc::sync::Arc<foreign_vec::ForeignVec<arrow2::buffer::BytesAllocator, f32>, alloc::alloc::Global>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#32 core::ptr::drop_in_place<arrow2::buffer::immutable::Buffer<f32>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#33 core::ptr::drop_in_place<arrow2::array::primitive::PrimitiveArray<f32>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#34 0x00007f2bb63fb62b in core::ptr::drop_in_place<alloc::boxed::Box<dyn arrow2::array::Array, alloc::alloc::Global>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#35 core::ptr::drop_in_place<arrow2::array::fixed_size_list::FixedSizeListArray> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#36 0x00007f2bb6204815 in core::ptr::drop_in_place<alloc::boxed::Box<dyn arrow2::array::Array, alloc::alloc::Global>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#37 core::ptr::drop_in_place<arrow2::array::list::ListArray<i32>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#38 0x00007f2bb62043f7 in core::ptr::drop_in_place<alloc::boxed::Box<dyn arrow2::array::Array, alloc::alloc::Global>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#39 core::ptr::drop_in_place<[alloc::boxed::Box<dyn arrow2::array::Array, alloc::alloc::Global>]> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#40 alloc::vec::{impl#24}::drop<alloc::boxed::Box<dyn arrow2::array::Array, alloc::alloc::Global>, alloc::alloc::Global> (self=0x25200072448) at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/alloc/src/vec/mod.rs:3066
#41 core::ptr::drop_in_place<alloc::vec::Vec<alloc::boxed::Box<dyn arrow2::array::Array, alloc::alloc::Global>, alloc::alloc::Global>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#42 core::ptr::drop_in_place<arrow2::chunk::Chunk<alloc::boxed::Box<dyn arrow2::array::Array, alloc::alloc::Global>>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#43 core::ptr::drop_in_place<re_log_types::arrow_msg::ArrowMsg> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#44 0x00007f2bb5db8748 in core::ptr::drop_in_place<[re_log_types::LogMsg]> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#45 alloc::vec::{impl#24}::drop<re_log_types::LogMsg, alloc::alloc::Global> (self=0x251fc030d88) at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/alloc/src/vec/mod.rs:3066
#46 core::ptr::drop_in_place<alloc::vec::Vec<re_log_types::LogMsg, alloc::alloc::Global>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#47 0x00007f2bb552b5aa in core::ptr::drop_in_place<alloc::boxed::Box<dyn re_sdk::log_sink::LogSink, alloc::alloc::Global>> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ptr/mod.rs:497
#48 re_sdk::recording_stream::forwarding_thread (info=..., sink=..., cmds_rx=..., tables=...) at crates/re_sdk/src/recording_stream.rs:998
#49 0x00007f2bb552ff15 in re_sdk::recording_stream::{impl#2}::new::{closure#0} () at crates/re_sdk/src/recording_stream.rs:599
#50 std::sys_common::backtrace::__rust_begin_short_backtrace<re_sdk::recording_stream::{impl#2}::new::{closure_env#0}, ()> (f=...) at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/std/src/sys_common/backtrace.rs:154
#51 0x00007f2bb5539eb7 in std::thread::{impl#0}::spawn_unchecked_::{closure#1}::{closure#0}<re_sdk::recording_stream::{impl#2}::new::{closure_env#0}, ()> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/std/src/thread/mod.rs:529
#52 core::panic::unwind_safe::{impl#23}::call_once<(), std::thread::{impl#0}::spawn_unchecked_::{closure#1}::{closure_env#0}<re_sdk::recording_stream::{impl#2}::new::{closure_env#0}, ()>> (self=<error reading variable: Cannot access memory at address 0x30>) at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/panic/unwind_safe.rs:271
#53 std::panicking::try::do_call<core::panic::unwind_safe::AssertUnwindSafe<std::thread::{impl#0}::spawn_unchecked_::{closure#1}::{closure_env#0}<re_sdk::recording_stream::{impl#2}::new::{closure_env#0}, ()>>, ()> (data=<optimized out>) at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/std/src/panicking.rs:504
#54 std::panicking::try<(), core::panic::unwind_safe::AssertUnwindSafe<std::thread::{impl#0}::spawn_unchecked_::{closure#1}::{closure_env#0}<re_sdk::recording_stream::{impl#2}::new::{closure_env#0}, ()>>> (f=<error reading variable: Cannot access memory at address 0x30>) at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/std/src/panicking.rs:468
#55 std::panic::catch_unwind<core::panic::unwind_safe::AssertUnwindSafe<std::thread::{impl#0}::spawn_unchecked_::{closure#1}::{closure_env#0}<re_sdk::recording_stream::{impl#2}::new::{closure_env#0}, ()>>, ()> (f=<error reading variable: Cannot access memory at address 0x30>) at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/std/src/panic.rs:142
#56 std::thread::{impl#0}::spawn_unchecked_::{closure#1}<re_sdk::recording_stream::{impl#2}::new::{closure_env#0}, ()> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/std/src/thread/mod.rs:528
#57 core::ops::function::FnOnce::call_once<std::thread::{impl#0}::spawn_unchecked_::{closure_env#1}<re_sdk::recording_stream::{impl#2}::new::{closure_env#0}, ()>, ()> () at /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/ops/function.rs:250
#58 0x00007f2bb66d6a05 in alloc::boxed::{impl#47}::call_once<(), dyn core::ops::function::FnOnce<(), Output=()>, alloc::alloc::Global> () at library/alloc/src/boxed.rs:2007
#59 alloc::boxed::{impl#47}::call_once<(), alloc::boxed::Box<dyn core::ops::function::FnOnce<(), Output=()>, alloc::alloc::Global>, alloc::alloc::Global> () at library/alloc/src/boxed.rs:2007
#60 std::sys::unix::thread::{impl#2}::new::thread_start () at library/std/src/sys/unix/thread.rs:108
#61 0x00007f2c088aa9eb in ?? () from /usr/lib/libc.so.6
#62 0x00007f2c0892e7cc in ?? () from /usr/lib/libc.so.6

@teh-cmc
Copy link
Member

teh-cmc commented Dec 1, 2023

from __future__ import annotations

import rerun as rr

# this works
rec = rr.new_recording(application_id="test")

# this crashes (coredump)
rec = rr.new_recording(application_id="test")
rr.log("test", rr.Points3D([1, 2, 3]), recording=rec.inner)

# this works
rec = rr.new_recording(application_id="test", make_default=True)
rr.log("test", rr.Points3D([1, 2, 3]), recording=rec.inner)

# this crashes (but with a segfault this time)
rec = rr.new_recording(application_id="test", make_thread_default=True)
rr.log("test", rr.Points3D([1, 2, 3]), recording=rec.inner)

# this works
rec = rr.new_recording(application_id="test") # this works
rr.set_global_data_recording(rec)
rr.log("test", rr.Points3D([1, 2, 3]), recording=rec.inner)

# this crashes (but with a segfault this time)
rec = rr.new_recording(application_id="test") # this works
rr.set_thread_local_data_recording(rec)
rr.log("test", rr.Points3D([1, 2, 3]), recording=rec.inner)

# this works!
rec = rr.new_recording(application_id="test", spawn=True)
rr.log("test", rr.Points3D([1, 2, 3]), recording=rec.inner)

# this works!
rec = rr.new_recording(application_id="test")
rr.connect(recording=rec)
rr.log("test", rr.Points3D([1, 2, 3]), recording=rec.inner)

# this works!
rec = rr.new_recording(application_id="test")
rr.memory_recording(recording=rec)
rr.log("test", rr.Points3D([1, 2, 3]), recording=rec.inner)

@teh-cmc
Copy link
Member

teh-cmc commented Dec 1, 2023

Alright I see the problem and have a dirty fix working but gotta run!

@teh-cmc
Copy link
Member

teh-cmc commented Jan 2, 2024

@teh-cmc teh-cmc closed this as completed Jan 2, 2024
emilk added a commit that referenced this issue May 29, 2024
* Uses: rerun-io/egui_tiles#67
* Uses: lampsitter/egui_commonmark#51
* Split off from #6171
* Closes #5280

### Test
* [x] image loading
* [x] gltf
 
### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6448?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6448?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6448)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

# egui changelog so far

Full diff at https://github.com/emilk/egui/compare/0.27.0..HEAD

#### ecolor
* Fix `hex_color!` macro by re-exporting `color_hex` crate from `ecolor`
[#4372](emilk/egui#4372) (thanks
[@dataphract](https://github.com/dataphract)!)
* Remove `extra_asserts` and `extra_debug_asserts` feature flags
[#4478](emilk/egui#4478)

#### eframe
* Add `register_native_texture` in `eframe::Frame`
[#4246](emilk/egui#4246) (thanks
[@Chaojimengnan](https://github.com/Chaojimengnan)!)
* Early-out from context switching the `glow` backend
[#4284](emilk/egui#4284)
* Fix `ViewportCommand::InnerSize` not resizing viewport on Wayland
(#4211) [#4211](emilk/egui#4211) (thanks
[@rustbasic](https://github.com/rustbasic)!)
* Only avoid glow context switching on Windows
[#4296](emilk/egui#4296)
* Improve IME support with new `Event::Ime`
[#4358](emilk/egui#4358) (thanks
[@rustbasic](https://github.com/rustbasic)!)
* Allow users to create viewports larger than monitor on Windows & macOS
[#4337](emilk/egui#4337) (thanks
[@lopo12123](https://github.com/lopo12123)!)
* Use `objc2` and its framework crates
[#4395](emilk/egui#4395) (thanks
[@madsmtm](https://github.com/madsmtm)!)
* Update to Rust 1.76 [#4411](emilk/egui#4411)
* Egui-winit: emit physical key presses when a non-Latin layout is
active [#4461](emilk/egui#4461) (thanks
[@TicClick](https://github.com/TicClick)!)
* IME for chinese [#4436](emilk/egui#4436)
(thanks [@rustbasic](https://github.com/rustbasic)!)
* Fix : In Windows, the 'egui_demo_app' screen does not appear.
[#4410](emilk/egui#4410) (thanks
[@rustbasic](https://github.com/rustbasic)!)
* Fix: Window position creeps between executions on scaled monitors
[#4443](emilk/egui#4443) (thanks
[@avery-radmacher](https://github.com/avery-radmacher)!)
* Update `image` crate to 0.25
[#4160](emilk/egui#4160)
* Ignore synthetic key presses
[#4514](emilk/egui#4514) (thanks
[@hut](https://github.com/hut)!)
* Fix: still track mouse when dragging outside web canvas
[#4522](emilk/egui#4522)
* Add `NativeOptions::persistence_path`
[#4423](emilk/egui#4423) (thanks
[@lucasmerlin](https://github.com/lucasmerlin)!)
* Use ResizeObserver instead of `resize` event
[#4536](emilk/egui#4536) (thanks
[@jprochazk](https://github.com/jprochazk)!)
* Fix: Don't `.forget()` RAF closure
[#4551](emilk/egui#4551) (thanks
[@jprochazk](https://github.com/jprochazk)!)

#### egui_extras
* Update `image` crate to 0.25
[#4160](emilk/egui#4160)

#### egui_plot
* `Plot::Items:allow_hover` give possibility to masked the interaction
on hovered item [#2558](emilk/egui#2558) (thanks
[@haricot](https://github.com/haricot)!)
* Expose `ClosestElem` and `PlotConfig`
[#4380](emilk/egui#4380) (thanks
[@Narcha](https://github.com/Narcha)!)
* Disable interaction for `ScrollArea` and `Plot` when UI is disabled
[#4457](emilk/egui#4457) (thanks
[@varphone](https://github.com/varphone)!)
* Make sure plot size is positive
[#4429](emilk/egui#4429) (thanks
[@rustbasic](https://github.com/rustbasic)!)
* Introduce lifetime to `egui_plot::Plot` to replace `'static` fields
[#4435](emilk/egui#4435) (thanks
[@Fabus1184](https://github.com/Fabus1184)!)
* Hide all other series when alt-clicking in the legend
[#4549](emilk/egui#4549) (thanks
[@abey79](https://github.com/abey79)!)
* Plot now respects the `interact_radius` set in the UI's style
[#4520](emilk/egui#4520) (thanks
[@YgorSouza](https://github.com/YgorSouza)!)

#### egui_glow
* Enable egui_glow's winit feature on wasm (#4420)
[#4421](emilk/egui#4421) (thanks
[@simon-frankau](https://github.com/simon-frankau)!)

#### egui-wgpu
* Update to wgpu 0.20 [#4433](emilk/egui#4433)
(thanks [@KeKsBoTer](https://github.com/KeKsBoTer)!)
* Revert update to wgpu 0.20 => downgrade to wgpu 0.19.1
[#4559](emilk/egui#4559)

#### egui-winit
* Update `webbrowser` to `v1.0.0`
[#4394](emilk/egui#4394) (thanks
[@torokati44](https://github.com/torokati44)!)
* Emit physical key presses when a non-Latin layout is active
[#4461](emilk/egui#4461) (thanks
[@TicClick](https://github.com/TicClick)!)
* IME for chinese [#4436](emilk/egui#4436)
(thanks [@rustbasic](https://github.com/rustbasic)!)
* Fix: Window position creeps between executions on scaled monitors
[#4443](emilk/egui#4443) (thanks
[@avery-radmacher](https://github.com/avery-radmacher)!)
* Ignore synthetic key presses
[#4514](emilk/egui#4514) (thanks
[@hut](https://github.com/hut)!)

#### egui
* Improve the UI for changing the egui theme
[#4257](emilk/egui#4257)
* Change the resize cursor when you reach the resize limit
[#4275](emilk/egui#4275)
* Make `TextEdit` an atomic widget
[#4276](emilk/egui#4276)
* Overload operators for `Rect + Margin`, `Rect - Margin` etc
[#4277](emilk/egui#4277)
* Implement blinking text cursor in `TextEdit`
[#4279](emilk/egui#4279)
* Rename `fn scroll2` to `fn scroll`
[#4282](emilk/egui#4282)
* Change `Frame::multiply_with_opacity` to multiply in gamma space
[#4283](emilk/egui#4283)
* Support order on windows
[#4301](emilk/egui#4301) (thanks
[@alexparlett](https://github.com/alexparlett)!)
* Fix wrong replacement function in deprecation notice of
`drag_released*` [#4314](emilk/egui#4314)
(thanks [@sornas](https://github.com/sornas)!)
* Consider layer transform when positioning text agent
[#4319](emilk/egui#4319) (thanks
[@juancampa](https://github.com/juancampa)!)
* Fix incorrect line breaks
[#4377](emilk/egui#4377) (thanks
[@juancampa](https://github.com/juancampa)!)
* Fix `hex_color!` macro by re-exporting `color_hex` crate from `ecolor`
[#4372](emilk/egui#4372) (thanks
[@dataphract](https://github.com/dataphract)!)
* Change `Ui::allocate_painter` to inherit properties from `Ui`
[#4343](emilk/egui#4343) (thanks
[@varphone](https://github.com/varphone)!)
* Use parent `Ui`s style for popups
[#4325](emilk/egui#4325) (thanks
[@alexparlett](https://github.com/alexparlett)!)
* Fix : take `rounding` into account when using `Slider::trailing_fill`
[#4308](emilk/egui#4308) (thanks
[@rustbasic](https://github.com/rustbasic)!)
* Add a way to specify Undoer settings and construct Undoers more easily
[#4357](emilk/egui#4357) (thanks
[@valadaptive](https://github.com/valadaptive)!)
* Add xtask crate [#4293](emilk/egui#4293)
(thanks [@YgorSouza](https://github.com/YgorSouza)!)
* Add `ViewportCommand::RequestCut`, `RequestCopy` and `RequestPaste` to
trigger Clipboard actions
[#4035](emilk/egui#4035) (thanks
[@bu5hm4nn](https://github.com/bu5hm4nn)!)
* Fix `Panel` incorrect size
[#4351](emilk/egui#4351) (thanks
[@zhatuokun](https://github.com/zhatuokun)!)
* Improve IME support with new `Event::Ime`
[#4358](emilk/egui#4358) (thanks
[@rustbasic](https://github.com/rustbasic)!)
* Allow users to create viewports larger than monitor on Windows & macOS
[#4337](emilk/egui#4337) (thanks
[@lopo12123](https://github.com/lopo12123)!)
* Added ability to define colors at UV coordinates along a path
[#4353](emilk/egui#4353) (thanks
[@murl-digital](https://github.com/murl-digital)!)
* Eframe: update ViewportBuilder.with_icon() documentation
[#4408](emilk/egui#4408) (thanks
[@roccoblues](https://github.com/roccoblues)!)
* Update to Rust 1.76 [#4411](emilk/egui#4411)
* Add a `Display` impl for `Vec2`, `Pos2`, and `Rect`
[#4428](emilk/egui#4428) (thanks
[@tgross35](https://github.com/tgross35)!)
* Remove `extra_asserts` and `extra_debug_asserts` feature flags
[#4478](emilk/egui#4478)
* Egui-winit: emit physical key presses when a non-Latin layout is
active [#4461](emilk/egui#4461) (thanks
[@TicClick](https://github.com/TicClick)!)
* Disable interaction for `ScrollArea` and `Plot` when UI is disabled
[#4457](emilk/egui#4457) (thanks
[@varphone](https://github.com/varphone)!)
* Update ahash 0.8.6 -> 0.8.11
[#4507](emilk/egui#4507) (thanks
[@hellodword](https://github.com/hellodword)!)
* `include_image!` now accepts expressions
[#4521](emilk/egui#4521) (thanks
[@YgorSouza](https://github.com/YgorSouza)!)
* Remove `Event::Scroll` and handle it in egui
[#4524](emilk/egui#4524)
* Remove scroll latency for smooth trackpads
[#4526](emilk/egui#4526)
* Smooth out zooming with discreet scroll wheel
[#4530](emilk/egui#4530)
* Add `Options::line_scroll_speed` and `scroll_zoom_speed`
[#4532](emilk/egui#4532)
* Don't panic when replacement glyph is not found
[#4542](emilk/egui#4542) (thanks
[@RyanBluth](https://github.com/RyanBluth)!)
* Make `TextEdit::return_key` optional
[#4543](emilk/egui#4543) (thanks
[@doonv](https://github.com/doonv)!)
* Add `TextEdit::hint_text_font`
[#4517](emilk/egui#4517) (thanks
[@zaaarf](https://github.com/zaaarf)!)
* Add `Options::reduce_texture_memory` to free up RAM
[#4431](emilk/egui#4431) (thanks
[@varphone](https://github.com/varphone)!)
* Fix `Ui::scroll_with_delta` only scrolling if the `ScrollArea` is
focused [#4303](emilk/egui#4303) (thanks
[@lucasmerlin](https://github.com/lucasmerlin)!)
* Add support for text truncation to `egui::Style`
[#4556](emilk/egui#4556) (thanks
[@abey79](https://github.com/abey79)!)
* Hide toolip when opening `ComboBox` drop-down
[#4546](emilk/egui#4546) (thanks
[@abey79](https://github.com/abey79)!)
* Better spacing and sizes for (menu) buttons
[#4558](emilk/egui#4558)

#### epaint
* Add `RectShape::blur_width` to implement shadows
[#4267](emilk/egui#4267)
* Overload operators for `Rect + Margin`, `Rect - Margin` etc
[#4277](emilk/egui#4277)
* Fix incorrect line breaks
[#4377](emilk/egui#4377) (thanks
[@juancampa](https://github.com/juancampa)!)
* Fix `hex_color!` macro by re-exporting `color_hex` crate from `ecolor`
[#4372](emilk/egui#4372) (thanks
[@dataphract](https://github.com/dataphract)!)
* Add `emath::OrderedFloat` (moved from `epaint::util::OrderedFloat`)
[#4389](emilk/egui#4389)
* Added ability to define colors at UV coordinates along a path
[#4353](emilk/egui#4353) (thanks
[@murl-digital](https://github.com/murl-digital)!)
* Add a `Display` impl for `Vec2`, `Pos2`, and `Rect`
[#4428](emilk/egui#4428) (thanks
[@tgross35](https://github.com/tgross35)!)
* Remove `extra_asserts` and `extra_debug_asserts` feature flags
[#4478](emilk/egui#4478)
* Make `epaint::mutex::RwLock` allow `?Sized` types
[#4485](emilk/egui#4485) (thanks
[@crumblingstatue](https://github.com/crumblingstatue)!)
* Update ahash 0.8.6 -> 0.8.11
[#4507](emilk/egui#4507) (thanks
[@hellodword](https://github.com/hellodword)!)
* Don't panic when replacement glyph is not found
[#4542](emilk/egui#4542) (thanks
[@RyanBluth](https://github.com/RyanBluth)!)

---------

Co-authored-by: Antoine Beyeler <[email protected]>
Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🐍 Python API Python logging API
Projects
None yet
Development

No branches or pull requests

3 participants