-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python SDK: introduce deferred garbage collection queue #4583
Conversation
c1a2bc8
to
1950030
Compare
3ae1791
to
74e7d45
Compare
74e7d45
to
eaf8383
Compare
This feels like it might be a better implementation of the attempted workaround that existed in buffered_client: I suspect this means that code can go away and stuff can be safely dropped after packet sending instead of shuffling off to yet-another thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
Nice catch, it's gone 🥳 |
This introduces a new deferred system to clear Arrow garbage that was originally allocated in Python land.
This should fix all deadlocks/segfaults/aborts past, present and future... or not 🥲
NOTE: This lives in parallel to the already existing
ALL_RECORDINGS
thingy, which is still needed to avoid killing and joining threads at a bad time.Checklist
main
build: app.rerun.ionightly
build: app.rerun.io