Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging ViewCoordinates at / silently does nothing #3538

Closed
teh-cmc opened this issue Sep 29, 2023 · 0 comments · Fixed by #3748
Closed

Logging ViewCoordinates at / silently does nothing #3538

teh-cmc opened this issue Sep 29, 2023 · 0 comments · Fixed by #3748
Assignees
@jleibs
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🍏 primitives Relating to Rerun primitives ui concerns graphical user interface
Milestone
0.9.1

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Sep 29, 2023

We should either warn or even better (?) make it work.
@teh-cmc teh-cmc added 🪳 bug Something isn't working ui concerns graphical user interface 🍏 primitives Relating to Rerun primitives labels Sep 29, 2023
@teh-cmc teh-cmc mentioned this issue Sep 29, 2023
Closed
@teh-cmc teh-cmc added the 😤 annoying Something in the UI / SDK is annoying to use label Sep 29, 2023
@teh-cmc teh-cmc mentioned this issue Sep 29, 2023
Merged
6 tasks
@emilk emilk added this to the 0.9.1 milestone Oct 9, 2023
@jleibs jleibs self-assigned this Oct 9, 2023
@jleibs jleibs mentioned this issue Oct 9, 2023
Merged
4 tasks
@emilk emilk mentioned this issue Oct 10, 2023
Closed
teh-cmc pushed a commit that referenced this issue Oct 10, 2023
@jleibs
Display space views using view coordinates from closest ancestor. (#3748
01a0f68 
)

### What
View coordinates are a bit special -- we want to respect them even if
they are not explicitly part of the given space-view.

Resolves: #3538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleibs jleibs

Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🍏 primitives Relating to Rerun primitives ui concerns graphical user interface
Projects
None yet
Milestone
0.9.1
Development

Successfully merging a pull request may close this issue.

Display space views using ViewCoordinates from closest ancestor. rerun-io/rerun
3 participants
@emilk @teh-cmc @jleibs