-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orbital camera should always maintain an up axis internally #3539
Labels
Comments
teh-cmc
added
ui
concerns graphical user interface
😤 annoying
Something in the UI / SDK is annoying to use
labels
Sep 29, 2023
teh-cmc
changed the title
Orbital camera tilting is unfriendly without explicit
Orbital camera should always maintain an up axis internally
Sep 29, 2023
ViewCoordinates
4 tasks
5 tasks
emilk
added a commit
that referenced
this issue
Feb 15, 2024
* Continuing the work in #3817 ### What - The orbit eye now always maintains an up axis internally (+Z by default, if there is no `ViewCoordinates`). - When a user rolls the camera (middle mouse drag), we now change the internal up-axis, which makes rolling then orbiting a much better experience as you don't end up in a weird state with no up axis. - The orbit eye center visualization now indicates the current up-axis https://github.com/rerun-io/rerun/assets/1148717/daeb1e57-8fe3-4ac9-84fc-c673bb70ad09 - Fixes #3539 - Fixes #3420 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5193/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5193/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5193/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5193) - [Docs preview](https://rerun.io/preview/c4c8821a33c3df282e31c64ca1d719358666b72a/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/c4c8821a33c3df282e31c64ca1d719358666b72a/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Clement Rey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The orbital camera works great when you've explicitly logged
ViewCoordinates
(which has its own issues... #3538), but when you don't, the camera will be in permanent tilt-mode where it is almost impossible to position it the way you'd like as it'll keep tilting when all you're trying to do is rotate around your focus point.We should have a default up axis when no viewcoordinates are set. It doesn't matter what that up axis is, as long as users can modify it (which they already can using e.g. mouse click... except not really, see next point).
There is another issue though: when users explicitly enter tilt-mode today (e.g. using middle mouse click), we completely drop the notion of an up-axis altogether, and so we enter a weird state where there is no up axis at all and the camera once again becomes very hard to use.
We should always have an up-axis internally (which is either the default one, or one coming from a
ViewCoordinates
), and middle clicking should modify that up-axis as required.The text was updated successfully, but these errors were encountered: