Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display space views using ViewCoordinates from closest ancestor. #3748

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Display space views using ViewCoordinates from closest ancestor. #3748

merged 3 commits into from
Oct 10, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 9, 2023 •
edited by github-actions bot
Loading

What

View coordinates are a bit special -- we want to respect them even if they are not explicitly part of the given space-view.

Resolves: #3538

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added 📺 re_viewer affects re_viewer itself include in changelog labels Oct 9, 2023
@jleibs jleibs changed the title Use view coordinates at closest ancestor. Display space views using view coordinates from closest ancestor. Oct 9, 2023
@jleibs jleibs marked this pull request as ready for review October 9, 2023 18:56
@jleibs jleibs added this to the 0.9.1 milestone Oct 10, 2023
@teh-cmc teh-cmc merged commit 01a0f68 into main Oct 10, 2023
28 checks passed
@teh-cmc teh-cmc deleted the jleibs/view_coords_closest_ancestor branch October 10, 2023 10:07
@emilk emilk changed the title Display space views using view coordinates from closest ancestor. Display space views using ViewCoordinates from closest ancestor. Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

Logging ViewCoordinates at / silently does nothing
3 participants
@jleibs @emilk @teh-cmc