chore(instrumentation): add timing statistics for getReleases

[justfalter]

Changes

Adds collection and reporting of timing statistics for datasource.getReleases() calls. Each call records the datasource, registryUrl, packageName, and duration. The intent is to provide much-needed visibility into where renovate is retrieving release information and how long that might take. I plan on using this functionality to identify ways to speed up our renovate jobs.

The report consists of a nested data-structure that provides increasing detail as we descend datasource, registryUrl, and packageName.

The full report is logged at trace level
getReleases statistics with packages.

A summary report including only datasources and registryUrls is logged at debug level getReleases statistics summary.

Example fetching from large monorepos:: https://github.com/justfalter/renovate-test-repo/actions/runs/24215053173/job/70693432571#step:4:11559

From the statistics, we can see that github-tags spent considerable amount of time fetching releases/changelogs for aws/aws-sdk-go-v2 (~699s) and aws/aws-sdk-js-v3 (~111s) via https://api.github.com. In my environment, I would consider disabling the fetching of changelogs for at least the go package as I do feel they are worth the wait (example).

INFO: getReleases statistics with packages (repository=justfalter/renovate-test-repo)
       "stats": {
         "count": 20,
         "avgMs": 41784,
         "medianMs": 1081,
         "maxMs": 699369,
         "totalMs": 835671
       },
       "datasources": {
         "golang-version": {
           "stats": {
             "count": 1,
             "avgMs": 200,
             "medianMs": 200,
             "maxMs": 200,
             "totalMs": 200
           },
           "registryUrls": {
             "https://raw.githubusercontent.com/golang/website": {
               "stats": {
                 "count": 1,
                 "avgMs": 200,
                 "medianMs": 200,
                 "maxMs": 200,
                 "totalMs": 200
               },
               "packages": {
                 "go": {
                   "count": 1,
                   "avgMs": 200,
                   "medianMs": 200,
                   "maxMs": 200,
                   "totalMs": 200
                 }
               }
             }
           }
         },
         "node-version": {
           "stats": {
             "count": 1,
             "avgMs": 380,
             "medianMs": 380,
             "maxMs": 380,
             "totalMs": 380
           },
           "registryUrls": {
             "https://nodejs.org/dist": {
               "stats": {
                 "count": 1,
                 "avgMs": 380,
                 "medianMs": 380,
                 "maxMs": 380,
                 "totalMs": 380
               },
               "packages": {
                 "node": {
                   "count": 1,
                   "avgMs": 380,
                   "medianMs": 380,
                   "maxMs": 380,
                   "totalMs": 380
                 }
               }
             }
           }
         },
         "go": {
           "stats": {
             "count": 9,
             "avgMs": 654,
             "medianMs": 549,
             "maxMs": 1917,
             "totalMs": 5884
           },
           "registryUrls": {
             "": {
               "stats": {
                 "count": 9,
                 "avgMs": 654,
                 "medianMs": 549,
                 "maxMs": 1917,
                 "totalMs": 5884
               },
               "packages": {
                 "github.com/aws/smithy-go": {
                   "count": 1,
                   "avgMs": 549,
                   "medianMs": 549,
                   "maxMs": 549,
                   "totalMs": 549
                 },
                 "github.com/aws/aws-sdk-go-v2": {
                   "count": 2,
                   "avgMs": 516,
                   "medianMs": 1026,
                   "maxMs": 1026,
                   "totalMs": 1031
                 },
                 "github.com/aws/aws-sdk-go-v2/internal/endpoints/v2": {
                   "count": 2,
                   "avgMs": 578,
                   "medianMs": 1145,
                   "maxMs": 1145,
                   "totalMs": 1155
                 },
                 "github.com/aws/aws-sdk-go-v2/internal/configsources": {
                   "count": 2,
                   "avgMs": 610,
                   "medianMs": 1212,
                   "maxMs": 1212,
                   "totalMs": 1220
                 },
                 "github.com/aws/aws-sdk-go-v2/service/account": {
                   "count": 2,
                   "avgMs": 965,
                   "medianMs": 1917,
                   "maxMs": 1917,
                   "totalMs": 1929
                 }
               }
             }
           }
         },
         "github-tags": {
           "stats": {
             "count": 5,
             "avgMs": 164956,
             "medianMs": 12348,
             "maxMs": 699369,
             "totalMs": 824778
           },
           "registryUrls": {
             "https://github.com/": {
               "stats": {
                 "count": 3,
                 "avgMs": 4800,
                 "medianMs": 1184,
                 "maxMs": 12348,
                 "totalMs": 14400
               },
               "packages": {
                 "actions/checkout": {
                   "count": 1,
                   "avgMs": 868,
                   "medianMs": 868,
                   "maxMs": 868,
                   "totalMs": 868
                 },
                 "actions/create-github-app-token": {
                   "count": 1,
                   "avgMs": 1184,
                   "medianMs": 1184,
                   "maxMs": 1184,
                   "totalMs": 1184
                 },
                 "renovatebot/github-action": {
                   "count": 1,
                   "avgMs": 12348,
                   "medianMs": 12348,
                   "maxMs": 12348,
                   "totalMs": 12348
                 }
               }
             },
             "https://api.github.com/": {
               "stats": {
                 "count": 2,
                 "avgMs": 405189,
                 "medianMs": 699369,
                 "maxMs": 699369,
                 "totalMs": 810378
               },
               "packages": {
                 "aws/aws-sdk-go-v2": {
                   "count": 1,
                   "avgMs": 699369,
                   "medianMs": 699369,
                   "maxMs": 699369,
                   "totalMs": 699369
                 },
                 "aws/aws-sdk-js-v3": {
                   "count": 1,
                   "avgMs": 111009,
                   "medianMs": 111009,
                   "maxMs": 111009,
                   "totalMs": 111009
                 }
               }
             }
           }
         },
         "npm": {
           "stats": {
             "count": 4,
             "avgMs": 1107,
             "medianMs": 1255,
             "maxMs": 2049,
             "totalMs": 4429
           },
           "registryUrls": {
             "https://registry.npmjs.org/": {
               "stats": {
                 "count": 4,
                 "avgMs": 1107,
                 "medianMs": 1255,
                 "maxMs": 2049,
                 "totalMs": 4429
               },
               "packages": {
                 "@aws-sdk/client-s3": {
                   "count": 2,
                   "avgMs": 563,
                   "medianMs": 1081,
                   "maxMs": 1081,
                   "totalMs": 1125
                 },
                 "pnpm": {
                   "count": 1,
                   "avgMs": 1255,
                   "medianMs": 1255,
                   "maxMs": 1255,
                   "totalMs": 1255
                 },
                 "typescript": {
                   "count": 1,
                   "avgMs": 2049,
                   "medianMs": 2049,
                   "maxMs": 2049,
                   "totalMs": 2049
                 }
               }
             }
           }
         }
       },
       "oldLevel": "trace"
INFO: getReleases statistics summary (repository=justfalter/renovate-test-repo)
       "stats": {
         "count": 20,
         "avgMs": 41784,
         "medianMs": 1081,
         "maxMs": 699369,
         "totalMs": 835671
       },
       "datasources": {
         "golang-version": {
           "stats": {
             "count": 1,
             "avgMs": 200,
             "medianMs": 200,
             "maxMs": 200,
             "totalMs": 200
           },
           "registryUrls": {
             "https://raw.githubusercontent.com/golang/website": {
               "stats": {
                 "count": 1,
                 "avgMs": 200,
                 "medianMs": 200,
                 "maxMs": 200,
                 "totalMs": 200
               }
             }
           }
         },
         "node-version": {
           "stats": {
             "count": 1,
             "avgMs": 380,
             "medianMs": 380,
             "maxMs": 380,
             "totalMs": 380
           },
           "registryUrls": {
             "https://nodejs.org/dist": {
               "stats": {
                 "count": 1,
                 "avgMs": 380,
                 "medianMs": 380,
                 "maxMs": 380,
                 "totalMs": 380
               }
             }
           }
         },
         "go": {
           "stats": {
             "count": 9,
             "avgMs": 654,
             "medianMs": 549,
             "maxMs": 1917,
             "totalMs": 5884
           },
           "registryUrls": {
             "": {
               "stats": {
                 "count": 9,
                 "avgMs": 654,
                 "medianMs": 549,
                 "maxMs": 1917,
                 "totalMs": 5884
               }
             }
           }
         },
         "github-tags": {
           "stats": {
             "count": 5,
             "avgMs": 164956,
             "medianMs": 12348,
             "maxMs": 699369,
             "totalMs": 824778
           },
           "registryUrls": {
             "https://github.com/": {
               "stats": {
                 "count": 3,
                 "avgMs": 4800,
                 "medianMs": 1184,
                 "maxMs": 12348,
                 "totalMs": 14400
               }
             },
             "https://api.github.com/": {
               "stats": {
                 "count": 2,
                 "avgMs": 405189,
                 "medianMs": 699369,
                 "maxMs": 699369,
                 "totalMs": 810378
               }
             }
           }
         },
         "npm": {
           "stats": {
             "count": 4,
             "avgMs": 1107,
             "medianMs": 1255,
             "maxMs": 2049,
             "totalMs": 4429
           },
           "registryUrls": {
             "https://registry.npmjs.org/": {
               "stats": {
                 "count": 4,
                 "avgMs": 1107,
                 "medianMs": 1255,
                 "maxMs": 2049,
                 "totalMs": 4429
               }
             }
           }
         }
       },
       "oldLevel": "debug"

Context

Please select one of the following:

• This closes an existing Issue, Closes: #
• This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

• No — I did not use AI for this contribution.
• Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
• Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
• Yes — other (please describe):

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests, but ran on a real repository, or
• Both unit tests + ran on a real repository

The public repository: https://github.com/justfalter/renovate-test-repo

[jamietanna]

Thanks, this looks reasonable!

I think my preference would be to get our instrument function (for OpenTelemetry) doing this instead, similar to how we have a GitOperationSpanProcessor that then handles the spans and calcuates this

This would give us:

• more instrumentation of these calls, which is good
• a pattern we're trying to follow going forwards

Thoughts on whether you'd be up for a refactor to follow this approach?

[jamietanna]

(I will say that we're also trying to nudge more towards OpenTelemetry where possible - but we know a lot of folks also rely on our logs, so having it in both is OK)

[viceice]

let's create a new span processor like the git one as Jamie suggested

[justfalter]

While I have instrumented many things with otel, I went with this approach because:

1. I (and probably most users) haven't t got otel collectors deployed in a place where I would need to perform the collection.
2. The log-style would definitely provide immediate benefit to a lot of users.

I would be happy to add otel instrumentation as a separate PR!

[jamietanna]

Yep, that's all good - not expecting everyone to have it, and logs should still be a reasonable place to look for this.

We're more thinking that we'd introduce something like #39596 to process the

Then we'd replace getReleasesInstrumented with using instrument with span/attributes we can pick up on with our SpanProcessor - looks very similar, and will make sure that we get free OTel instrumentation through it, alongside the logs side of things too

[justfalter]

Yep, that's all good - not expecting everyone to have it, and logs should still be a reasonable place to look for this.

We're more thinking that we'd introduce something like #39596 to process the

Then we'd replace getReleasesInstrumented with using instrument with span/attributes we can pick up on with our SpanProcessor - looks very similar, and will make sure that we get free OTel instrumentation through it, alongside the logs side of things too

Ahh, I see what you're saying. I can do that.

[jamietanna]

Awesome, thanks!

[justfalter]

@jamietanna Any thoughts on where code for a getReleases span-processor should call home?

[jamietanna]

lib/modules/datasource/span-processor.ts is probably a good place :)

[jamietanna]

Nice! Thank you

Couple of small comments

[jamietanna]

I can see we've also got:

         "go": {
           "stats": {
             "count": 2,
             "avgMs": 726,
             "medianMs": 1451.803416,
             "maxMs": 1451.803416,
             "totalMs": 1452.68625
           },
           "registryUrls": {
             "": {
               "stats": {
                 "count": 2,
                 "avgMs": 726,
                 "medianMs": 1451.803416,
                 "maxMs": 1451.803416,
                 "totalMs": 1452.68625
               }
             }
           }
         },

I assume that's an existing issue with the Go datasource where we don't treat it as a registryUrl?

[justfalter]

I can see we've also got:

         "go": {
           "stats": {
             "count": 2,
             "avgMs": 726,
             "medianMs": 1451.803416,
             "maxMs": 1451.803416,
             "totalMs": 1452.68625
           },
           "registryUrls": {
             "": {
               "stats": {
                 "count": 2,
                 "avgMs": 726,
                 "medianMs": 1451.803416,
                 "maxMs": 1451.803416,
                 "totalMs": 1452.68625
               }
             }
           }
         },

I assume that's an existing issue with the Go datasource where we don't treat it as a registryUrl?

registryUrl is optional on the config datatypes, we default to an empty string just to make things a bit more friendly --- I could make it undefined, if you'd prefer.

AFAICT, go just doesn't use registryUrl.

[justfalter]

Here's an action run that tests things from just before the last set of very minor renames and doc changes: https://github.com/justfalter/renovate-test-repo/actions/runs/24410601154

[github-actions]

Hi there,

You are using done comments which cause a lot of noise/notifications. Instead, please use GitHub's web interface to request another review. Please read our contributing guidelines to reduce noise.

Good luck,

The Renovate team

[viceice]

@jamietanna did you checked that it doesn't broke http spans again?

[justfalter]

@viceice

@jamietanna did you checked that it doesn't broke http spans again?

I think you're talking about this PR to fix: https://github.com/renovatebot/renovate/pull/42471/changes ? This PR didn't touch anything in the area of bootstrapping instrumenation, so I wouldn't expect it to have been impacted.

[github-actions]

🎉 This PR is included in version 43.120.0 🎉

The release is available on:

• GitHub release
• 43.120.0

Your semantic-release bot 📦🚀

[justfalter]

Local testing suggests that the http spans are working OK:

[jamietanna]

Yes @viceice I did see that HTTP spans were still working 👍

[viceice]

great, thanks for confirming. we don't have regression tests yet to automatically test that.