fix(git): don't pass extraCloneOpts to ls-remote when local clone exists - #42491
Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a case where
git ls-remotefails during a recursiverenovateRepository()call after automerge. InfetchBranchCommits(), skip injectingextraCloneOptsas-cflags when.git/HEADalready exists inlocalDir.With token auth,
getExtraCloneOpts()sets up http.extraHeader, which gets persisted in.git/config. Until now, the directory survived the recursive call andfetchBranchCommitsadded those same options again via-c, producing duplicate HTTP headers that servers reject with HTTP 400. See #42210 (comment) for details.Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: