Skip to content

fix(instrumentation): ensure instrumentation is initialised first #42471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamietanna merged 2 commits into from
Apr 8, 2026
Merged

fix(instrumentation): ensure instrumentation is initialised first #42471

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2de876a
fix(otel): instrumentation needs to done first
viceice Apr 8, 2026
e2a8f8c
Apply suggestions from code review
viceice Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions lib/renovate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,19 @@ import 'source-map-support/register.js';
import './punycode.cjs';

void (async (): Promise<void> => {
// ⚠️ Don't add code before this!
// This has to be imported before logger and other libraries which are instrumented.
const otel = await import('./instrumentation/index.ts');
otel.init();
(await import('./proxy.ts')).bootstrap();

// prints and exits the process if --version or --help is passed
const { parseEarlyFlags } =
await import('./workers/global/config/parse/cli.ts');
parseEarlyFlags();

// has to be imported before logger and other libraries which are instrumentalised
const otel = await import('./instrumentation/index.ts');
otel.init();
(await import('./proxy.ts')).bootstrap();

const logger = await import('./logger/index.ts');
/* v8 ignore next 3 -- not easily testable */
/* v8 ignore next -- not easily testable */
process.on('unhandledRejection', (err) => {
logger.logger.error({ err }, 'unhandledRejection');
});
Expand All @@ -25,7 +26,7 @@ void (async (): Promise<void> => {
process.exitCode = await otel.instrument('run', start);
await otel.shutdown(); //gracefully shutdown OpenTelemetry

/* v8 ignore next 3 -- no test required */
/* v8 ignore if -- no test required */
if (process.env.RENOVATE_X_HARD_EXIT) {
process.exit(process.exitCode);
}
Expand Down
Loading