fix(ansible-galaxy): space parsing

[kechigon]

Changes

When parsing requirement.yml, if there is a space at the end of a line, it is not parsed correctly.

Context

I tried Renovate with the following requirement.yml for verification purposes.

collections:
  - name: https://github.com/lowlydba/lowlydba.sqlserver.git
    type: git 
    version: 1.1.3

However, it did not work as intended, so I set the log level to debug and observed the following logs.

DEBUG: packageFiles with updates (repository=k-kurita/ansible_galaxy_sample, baseBranch=main)
       "config": {
         "ansible-galaxy": [
           {
             "deps": [
               {
                 "depType": "galaxy-collection",
                 "depName": "https://github.com/lowlydba/lowlydba.sqlserver.git",
                 "skipReason": "unsupported",
                 "updates": []
               }
             ],
             "packageFile": "requirements.yml"
           }
         ]
       }

After debugging, I found that this was caused by a space at the end of the type: git line. To prevent this, I have changed the way regular expressions.

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[rarkins]

Please add or update a test

[kechigon]

Please add or update a test

I am not familiar with the testing, can you tell me how to change it?

[rarkins]

The tests are in https://github.com/kechigon/renovate/blob/feat/update-ansiblegalaxy-parsing/lib/modules/manager/ansible-galaxy/extract.spec.ts

[rarkins]

I have updated the test to be more useful and I think it's demonstrating that this PR is not doing what you think it's doing - the dependency is still skipped

[kechigon]

I think it's demonstrating that this PR is not doing what you think it's doing - the dependency is still skipped

I found that the reason is that the string array passed to the extcractCollections function does not contain "version: 1.1.3".

I have inserted the debug code into /home/vagrant/renovate/lib/modules/manager/ansible-galaxy/extract.ts

65       console.log(collectionLines)  //This line
66       const collectionDeps = extractCollections(collectionLines);

The following was displayed

[
  'collections:',
  '  - name: https://github.com/lowlydba/lowlydba.sqlserver.git',
  '    type: git '
]

[rarkins]

Needs to pass the test

[kechigon]

In the case of a requirement.yml like the one set up this time, I found that the result of getSliceEndNumber is 1 smaller, so I fixed it. As a result, I was able to confirm that the currentValue contains the correct value.

[kechigon]

Regarding the failed test, I think toBe(10) is correct, not toBe(9). Can I fix it?

FAIL lib/modules/manager/ansible-galaxy/extract.spec.ts (506 MB heap size)
  ● modules/manager/ansible-galaxy/extract › getSliceEndNumber() › choose second block

    expect(received).toBe(expected) // Object.is equality

    Expected: 9
    Received: 10

      87 |     it('choose second block', () => {
      88 |       const res = getSliceEndNumber(5, 10, 5);
    > 89 |       expect(res).toBe(9);
         |                   ^
      90 |     });
      91 |   });
      92 | });

      at Object.<anonymous> (lib/modules/manager/ansible-galaxy/extract.spec.ts:89:19)


Error: expect(received).toBe(expected) // Object.is equality

Expected: 9
Received: 10

    at Object.<anonymous> (lib/modules/manager/ansible-galaxy/extract.spec.ts:89:19)

[viceice]

otherwise LGTM

[renovate-release]

🎉 This PR is included in version 35.42.0 🎉

The release is available on:

• GitHub release
• 35.42.0

Your semantic-release bot 📦🚀