Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(git): use rev-list count to determine behind base status #21036

Merged
merged 2 commits into from
Mar 19, 2023
Merged

feat(git): use rev-list count to determine behind base status #21036

merged 2 commits into from
Mar 19, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 19, 2023

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice March 19, 2023 12:04
@rarkins rarkins marked this pull request as draft March 19, 2023 12:06
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 19, 2023

This should be a big performance improvement on repos with many branches. Still needs some testing manually

viceice
viceice approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ better do real tests?

@rarkins rarkins marked this pull request as ready for review March 19, 2023 14:37
@rarkins rarkins added this pull request to the merge queue Mar 19, 2023
@rarkins rarkins merged commit 8a12dc6 into main Mar 19, 2023
@rarkins rarkins deleted the feat/git-behind branch March 19, 2023 15:00
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nikolaik nikolaik mentioned this pull request Mar 23, 2023
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rarkins @renovate-release @viceice