fix(platform/github): detect pr-edited if target changed #21026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
rarkins
requested changes
Mar 18, 2023
Co-authored-by: Rhys Arkins <[email protected]>
rarkins
previously approved these changes
Mar 18, 2023
viceice
previously approved these changes
Mar 19, 2023
The baseBranch was being updated from config instead of the targetBranch being updated in PR info ie. opposite if what we want to test for.
|
@viceice Sorry I had to make a change to the test. The test was working but it was testing a different case than intended. |
viceice
approved these changes
Mar 19, 2023
|
🎉 This PR is included in version 35.14.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
targetBranchto the list of returned fields after the PR info is coercedContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: