Skip to content

feat(cugraph-gnn): add libwholegraph Python build #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdice merged 4 commits into from
Apr 23, 2025
Merged

feat(cugraph-gnn): add libwholegraph Python build #494

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94b1cce
feat(cugraph-gnn): add libwholegraph Python build
gforsyth Apr 22, 2025
4197f1d
chore(revertme): point at fork for testing
gforsyth Apr 22, 2025
96c461a
Revert "chore(revertme): point at fork for testing"
gforsyth Apr 22, 2025
c4e6ed7
Merge branch 'branch-25.06' into libwholegraph
bdice Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,14 +203,18 @@ repos:

- name: cugraph-gnn
path: cugraph-gnn
git: {<<: *git_defaults, repo: cugraph-gnn}
git: {<<: *git_defaults, repo: cugraph-gnn, upstream: gforsyth, tag: wholegraph_wheel}

@bdice bdice Apr 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the testing changes to use your fork. If CI is failing for unrelated reasons (ucxx) we can just merge this as-is to unblock the other cugraph-gnn PR. The failing RAPIDS build jobs on this PR are non-blocking.

@gforsyth gforsyth Apr 22, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted. Thanks for the extra context!

@trxcllnt trxcllnt Apr 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdice Seems like the libucxx link error is related to statically linking libpython3.12.a. Maybe this version wasn't built with -fPIC? We could revert #492 back to using the os-provided Python 3.10.

@trxcllnt trxcllnt Apr 22, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR opened here: #495

@bdice bdice Apr 22, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with libucxx's pip devcontainer builds. Maybe we need to pass a different flag to not statically link Python? No idea. I am okay with any outcome here. I can approve #495.

cpp:
- name: wholegraph
sub_dir: cpp
depends: [raft]
args:
cmake: -DCMAKE_CUDA_ARCHITECTURES="${CUDAARCHS}"
python:
- name: libwholegraph
sub_dir: python/libwholegraph
depends: [wholegraph]
args: {install: *rapids_build_backend_args}
- name: pylibwholegraph
sub_dir: python/pylibwholegraph
depends: [wholegraph]
Expand Down