feat(cugraph-gnn): add libwholegraph Python build#494
Merged
bdice merged 4 commits intorapidsai:branch-25.06from Apr 23, 2025
Merged
feat(cugraph-gnn): add libwholegraph Python build#494bdice merged 4 commits intorapidsai:branch-25.06from
bdice merged 4 commits intorapidsai:branch-25.06from
Conversation
gforsyth
added
improvement
bdice
approved these changes
Apr 22, 2025
| - name: cugraph-gnn | ||
| path: cugraph-gnn | ||
| git: {<<: *git_defaults, repo: cugraph-gnn} | ||
| git: {<<: *git_defaults, repo: cugraph-gnn, upstream: gforsyth, tag: wholegraph_wheel} |
Contributor
There was a problem hiding this comment.
Please revert the testing changes to use your fork. If CI is failing for unrelated reasons (ucxx) we can just merge this as-is to unblock the other cugraph-gnn PR. The failing RAPIDS build jobs on this PR are non-blocking.
Contributor
Author
There was a problem hiding this comment.
Reverted. Thanks for the extra context!
Collaborator
Contributor
There was a problem hiding this comment.
I am not familiar with libucxx's pip devcontainer builds. Maybe we need to pass a different flag to not statically link Python? No idea. I am okay with any outcome here. I can approve #495.
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: rapidsai/build-planning#33
xref: rapidsai/cugraph-gnn#182
Add
libwholegraphwheels to the build manifest.Currently pointing at my fork in
cugraph-gnnfor testing.