Skip to content

Build shared libpython in pip base images#495

Merged
trxcllnt merged 6 commits intorapidsai:branch-25.06from
trxcllnt:fix/pip-python-os-provided
Apr 22, 2025
Merged

Build shared libpython in pip base images#495
trxcllnt merged 6 commits intorapidsai:branch-25.06from
trxcllnt:fix/pip-python-os-provided

Conversation

@trxcllnt
Copy link
Collaborator

This should fix the libucxx link error that cropped up:

  /usr/bin/ld: /usr/local/python/3.12.10/lib/libpython3.12.a(import.o): relocation R_X86_64_TPOFF32 against hidden symbol `pkgcontext' can not be used when making a shared object

@trxcllnt trxcllnt requested a review from a team as a code owner April 22, 2025 20:38
@trxcllnt trxcllnt requested review from AyodeAwe and removed request for a team April 22, 2025 20:38
@trxcllnt
Copy link
Collaborator Author

Alternatively, maybe we need to set "enableShared": true for the Python feature.

@bdice
Copy link
Contributor

bdice commented Apr 22, 2025

Alternatively, maybe we need to set "enableShared": true for the Python feature.

That might be helpful. Can we try that?

@trxcllnt
Copy link
Collaborator Author

trxcllnt commented Apr 22, 2025

@bdice yep, trying in 0651968. Building the image locally to test.

@trxcllnt trxcllnt force-pushed the fix/pip-python-os-provided branch from e6356ab to 0651968 Compare April 22, 2025 20:46
@trxcllnt
Copy link
Collaborator Author

trxcllnt commented Apr 22, 2025

@bdice I can confirm the enableShared: true option fixes the ucxx wheel link error 🎉

@trxcllnt trxcllnt changed the title Revert #492 and use os-provided python for pip base images Build shared libpython in pip base images Apr 22, 2025
@trxcllnt trxcllnt force-pushed the fix/pip-python-os-provided branch from daad853 to 6fda083 Compare April 22, 2025 21:34
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving the new changes. Let's see if CI passes before merging? Or if you feel comfortable with your local testing, feel free to move it forward.

@trxcllnt trxcllnt merged commit d1623dd into rapidsai:branch-25.06 Apr 22, 2025
171 of 173 checks passed
@trxcllnt trxcllnt deleted the fix/pip-python-os-provided branch April 22, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants