Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "--file_key" and "--prepend_channels" #89

Closed
jameslamb opened this issue May 13, 2024 · 1 comment · Fixed by #100
Closed

Remove "--file_key" and "--prepend_channels" #89

jameslamb opened this issue May 13, 2024 · 1 comment · Fixed by #100
Assignees
@jameslamb
Labels
released

Comments

@jameslamb
Copy link
Member

Description

In #71, the arguments --file_key and --prepend-channels were deprecated.

Uses of them across RAPIDS should be removed, and then they and the corresponding deprecation warnings here should be removed.

Benefits of this work

  • simplifies rapids-dependency-file-generator
  • removes a source of noise in CI logs across RAPIDS projects

Acceptance Criteria

  • 0 non-archived projects in the rapidsai org use --file_key or --prepend-channels in their calls to rapids-dependency-file-generator
  • arguments --file_key and --prepend-channels do not exist in rapids-dependency-file-generator

Approach

Across the rapidsai GitHub org:

  • replace --file_key with --file-key (note the -)
  • replace --prepend-channels with one or more --prepend-channel

For example this:

rapids-dependency-file-generator \
  --output conda \
  --file_key test_cpp \
  --matrix "cuda=12.2" \
  --prepend-channels "${CPP_CHANNEL};pytorch"

Should become this:

rapids-dependency-file-generator \
  --output conda \
  --file-key test_cpp \
  --matrix "cuda=12.2" \
  --prepend-channel "${CPP_CHANNEL}" \
  --prepend-channel "pytorch"

Notes

N/A
This was referenced Jun 3, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this issue Jun 10, 2024
@jameslamb
use rapids-build-backend (#1343)
abded3a 
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Proposes introducing `rapids-build-backend` as this project's build backend, to reduce the complexity of various CI/build scripts.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Lawrence Mitchell (https://github.com/wence-)
  - Ray Douglass (https://github.com/raydouglass)

URL: #1343
rapids-bot bot pushed a commit to rapidsai/cucim that referenced this issue Jun 10, 2024
@jameslamb
use rapids-build-backend (#736)
a6c4f59 
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Proposes introducing `rapids-build-backend` as this project's build backend, to reduce the complexity of various CI/build scripts.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Gregory Lee (https://github.com/grlee77)
  - Ray Douglass (https://github.com/raydouglass)

URL: #736
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this issue Jun 10, 2024
@jameslamb
use rapids-build-backend (#389)
e460b16 
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Proposes introducing `rapids-build-backend` as this project's build backend, to reduce the complexity of various CI/build scripts.

## Notes for Reviewers

### What about the ongoing work to add wheels?

If #369 is merged before this, this should be updated to ensure it doesn't break wheel builds.

But opening this one separately so we can keep making forward progress on rolling out `rapids-build-backend` across RAPIDS.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #389
rapids-bot bot pushed a commit to rapidsai/wholegraph that referenced this issue Jun 10, 2024
@jameslamb
use rapids-build-backend (#181)
c92bba3 
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Proposes introducing `rapids-build-backend` as this project's build backend, to reduce the complexity of various CI/build scripts.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #181
rapids-bot bot pushed a commit to rapidsai/cuxfilter that referenced this issue Jun 10, 2024
@jameslamb
use rapids-build-backend (#600)
2a2866c 
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Proposes introducing `rapids-build-backend` as this project's build backend, to reduce the complexity of various CI/build scripts.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Ajay Thorve (https://github.com/AjayThorve)

URL: #600
bdice added a commit to rapidsai/pynvjitlink that referenced this issue Jun 10, 2024
@jameslamb @bdice
use rapids-build-backend (#88)
e9d34ab 
Contributes to rapidsai/build-planning#31
Contributes to
rapidsai/dependency-file-generator#89

Proposes introducing `rapids-build-backend` as this project's build
backend, to reduce the complexity of various CI/build scripts.

---------

Co-authored-by: Bradley Dice <[email protected]>
@jameslamb jameslamb self-assigned this Jun 10, 2024
This was referenced Jun 10, 2024
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/ucxx that referenced this issue Jun 10, 2024
@jameslamb
use rapids-build-backend (#234)
1e6d80c 
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/build-planning#69
Contributes to rapidsai/dependency-file-generator#89

Proposes:

* introducing `rapids-build-backend` as this project's build backend, to reduce the complexity of various CI/build scripts
* using `pip install ./dist/*.whl` instead of `pip install --find-links ./dist` in CI, to reduce the risk of the types of bugs described in rapidsai/build-planning#69

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Ray Douglass (https://github.com/raydouglass)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #234
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this issue Jun 12, 2024
@jameslamb
use rapids-build-backend (#1393)
bc2ca80 
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Proposes introducing `rapids-build-backend` as this project's build backend, to reduce the complexity of various CI/build scripts.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1393
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this issue Jun 12, 2024
@jameslamb
resolve dependency-file-generator warning, remove unnecessary rapids-…
e28e0c7 
…build-backend configuration (#1582)

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

#1502 was one of the first `rapids-build-backend` PRs merged across RAPIDS. Since it was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `rmm` up with those changes:

* consolidates version-handling in `ci/build_cpp.sh`
* removes `commit-file` configuration in `pyproject.toml`
  - *as of rapidsai/rapids-build-backend#30, this is no longer necessary if the project's top-level directory is `{project_name}.replace("-", "_")*
  - *and anyway, it was changed from `commit-file` to `commit-files` in that PR, so `commit-file` was being silently ignored here*
* uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #1582
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue Jun 12, 2024
@jameslamb
resolve dependency-file-generator warning, remove unnecessary rapids-…
c0c2ad3 
…build-backend configuration (#15980)

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

#15245 was one of the first `rapids-build-backend` PRs merged across RAPIDS. Since it was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `cudf` up with those changes:

* consolidates version-handling in `ci/build_cpp.sh`
* removes `commit-file` configuration in `pyproject.toml`
  - *as of rapidsai/rapids-build-backend#30, this is no longer necessary if the project's top-level directory is `{project_name}.replace("-", "_")*
  - *and anyway, it was changed from `commit-file` to `commit-files` in that PR, so `commit-file` was being silently ignored here*
* uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Bradley Dice (https://github.com/bdice)

URL: #15980
rapids-bot bot pushed a commit to rapidsai/ucx-py that referenced this issue Jun 12, 2024
@jameslamb
use rapids-build-backend (#1044)
42c03ef 
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89
Contributes to rapidsai/build-planning#72

Proposes:

* introducing `rapids-build-backend` as this project's build backend, to reduce the complexity of various CI/build scripts
* making get-data-from-`pyproject.toml` code in conda recipe a bit stricter

## Notes for Reviewers

This reverts some of the workarounds introduced for docs builds in #1041. See this thread for context: #1041 (comment)

~To do that, I set 2 environment variables manually in in the readthedocs console ([link](https://readthedocs.org/dashboard/ucx-py/edit/)):~

* ~`RAPIDS_DISABLE_CUDA=true` = used to prevent needing `nvcc` in the docs-building environment~
* ~`RAPIDS_MATRIX_ENTRY='cuda=12.2'` = used to ensure that `pip install .` tries to install a real package (e.g. `libucx-cu12`)~

~I think this is the first place we're using the `rapids-build-backend` environment variable support.~

see #1044 (comment)

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #1044
This was referenced Jun 12, 2024
Merged
Merged
Merged
Merged
Merged
Merged
rapids-bot bot pushed a commit to rapidsai/cuvs that referenced this issue Jun 13, 2024
@jameslamb
resolve dependency-file-generator warning, rapids-build-backend follo…
771cc91 
…wup (#185)

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Since #145 was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `cuvs` up with those changes:

* consolidates version-handling in `ci/` scripts
* uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #185
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Jun 14, 2024
@jameslamb
resolve dependency-file-generator warning, other rapids-build-backend…
074055f 
… followup (#2360)

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Since #2331 was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `raft` up with those changes:

* consolidates version-handling in `ci/` scripts
* uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls
* reduces duplication of `rapids-build-backend` version constraint in `dependencies.yaml`, and renames some lists there to match the patterns used in other projects (e.g. `rapids_build_skbuild` instead of `build`)

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #2360
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this issue Jun 14, 2024
@jameslamb
resolve dependency-file-generator warning, other rapids-build-backend…
6342914 
… followup (#5928)

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

#5804 was one of the earlier `rapids-build-backend` PRs merged across RAPIDS. Since it was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `cuml` up with those changes:

* removes unused constants in `ci/build*` scripts
* uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls
* uses `--prepend-channel` instead of `--prepend-channels` in `rapids-dependency-file-generator` calls
* ensures `ci/update-version.sh` preserves alpha specs

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #5928
rapids-bot bot pushed a commit to rapidsai/docker that referenced this issue Jun 14, 2024
@jameslamb
resolve file_key deprecation warning from rapids-dependency-file-gene…
3668305 
…rator (#683)

Contributes to rapidsai/dependency-file-generator#89

Resolves this warning from `rapids-dependency-file-generator`.

> /opt/conda/lib/python3.9/site-packages/rapids_dependency_file_generator/cli.py:98: UserWarning: The use of --file_key is deprecated. Use -f or --file-key instead.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Mike Sarahan (https://github.com/msarahan)

URL: #683
raydouglass pushed a commit to rapidsai/jupyterlab-nvdashboard that referenced this issue Jun 14, 2024
@jameslamb
resolve file_key deprecation warning from rapids-dependency-file-gene…
7963f1e 
…rator (#198)

Contributes to
rapidsai/dependency-file-generator#89

Resolves this warning I see in build and test CI jobs, coming from
`rapids-dependency-file-generator`.

>
/opt/conda/lib/python3.9/site-packages/rapids_dependency_file_generator/cli.py:98:
UserWarning: The use of --file_key is deprecated. Use -f or --file-key
instead.
rapids-bot bot pushed a commit to nv-morpheus/MRC that referenced this issue Jun 17, 2024
@jameslamb
resolve rapids-dependency-file-generator warning (#482)
439d7df 
Contributes to rapidsai/dependency-file-generator#89.

`--file_key` has been deprecated in `rapids-dependency-file-generator` for a few months, and I'm looking to fully remove it.

This PR proposes:

* switching this project's uses from `--file_key` to `--file-key`
* updating the version of `rapids-dependency-file-generator` used in `pre-commit` to its latest release
* switching from `mamba env create --force` to `mamba env create --yes`

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Christopher Harris (https://github.com/cwharris)

URL: #482
@jameslamb jameslamb mentioned this issue Jun 17, 2024
Merged
copy-pr-bot bot pushed a commit to rapidsai/rmm that referenced this issue Jun 17, 2024
@jameslamb @rongou
resolve dependency-file-generator warning, remove unnecessary rapids-…
f91a680 
…build-backend configuration (#1582)

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

#1502 was one of the first `rapids-build-backend` PRs merged across RAPIDS. Since it was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `rmm` up with those changes:

* consolidates version-handling in `ci/build_cpp.sh`
* removes `commit-file` configuration in `pyproject.toml`
  - *as of rapidsai/rapids-build-backend#30, this is no longer necessary if the project's top-level directory is `{project_name}.replace("-", "_")*
  - *and anyway, it was changed from `commit-file` to `commit-files` in that PR, so `commit-file` was being silently ignored here*
* uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #1582
rapids-bot bot pushed a commit to nv-morpheus/Morpheus that referenced this issue Jun 25, 2024
@jameslamb
resolve rapids-dependency-file-generator warning (#1735)
7ec58a7 
Contributes to rapidsai/dependency-file-generator#89.

`--file_key` has been deprecated in `rapids-dependency-file-generator` for a few months, and I'm looking to fully remove it.

This PR proposes:

* switching this project's uses from `--file_key` to `--file-key`
* updating the version of `rapids-dependency-file-generator` used in `pre-commit` to its latest release

## By Submitting this PR I confirm:

- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Christopher Harris (https://github.com/cwharris)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #1735
@jameslamb jameslamb mentioned this issue Jul 1, 2024
Closed
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this issue Jul 1, 2024
@KyleFromNVIDIA
Use rapids-build-backend (#4393)
538a2ce 
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Proposes introducing `rapids-build-backend` as this project's build backend, to reduce the complexity of various CI/build scripts.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Mike Sarahan (https://github.com/msarahan)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Brad Rees (https://github.com/BradReesWork)

URL: #4393
@jameslamb jameslamb mentioned this issue Jul 2, 2024
Merged
@GPUtester
Copy link

🎉 This issue has been resolved in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jameslamb jameslamb mentioned this issue Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameslamb jameslamb

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): remove --file_key and --prepend-channels arguments jameslamb/dependency-file-generator
2 participants
@jameslamb @GPUtester