Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rapids-build-backend #145

Merged
merged 14 commits into from
May 31, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

Contributes to rapidsai/build-planning#31.

@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 22, 2024
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner May 22, 2024 19:48
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left 2 very very very minor comments... do whatever you want with them, and I don't need to review again when they're addressed.

dependencies.yaml Outdated Show resolved Hide resolved
python/cuvs/cuvs/_version.py Outdated Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments, but otherwise looks good! Resolve those as you see fit.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 09d674b into rapidsai:branch-24.08 May 31, 2024
55 checks passed
rapids-bot bot pushed a commit that referenced this pull request Jun 13, 2024
…wup (#185)

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Since #145 was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `cuvs` up with those changes:

* consolidates version-handling in `ci/` scripts
* uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants