-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use rapids-build-backend #1393
use rapids-build-backend #1393
Conversation
It looks like the
I see the same failures on #1384 (build link), so fairly confident that they're not related to the changes here. |
@@ -361,7 +383,7 @@ dependencies: | |||
common: | |||
- output_types: conda | |||
packages: | |||
- &rmm_conda rmm==24.8.* | |||
- &rmm_conda rmm==24.8.*,>=0.0.0a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this 0.0.0a0
mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
short answer
For conda, it's identical to just ==24.8.*
.
For pip
it means "I'm willing to accept any pre-releases of this package as well".
long answer
A version number like that is called a "pre-release".
Those are the version numbers we give to nightly RAPIDS packages.
By default, when you run pip install cuml-cu12==24.8.*
, such versions will be ignored. That's so package authors can publish packages like release candidates for testing.
One option to tell pip
you're open to installing such packages is to pass the --pre
flag to pip install
, like this:
pip install --pre 'cuml-cu12==24.8.*`
But that can have unintended consequences... --pre
applies through the entire dependency tree, so running a command like that would also mean you're saying "I'm willing to pull in any pre-releases of any of cuml-cu12
's dependencies as well".
Specifying a constraint like ,>=0.0.0a0
like this is a bit stricter... it tells pip
"I'm willing to pull in any pre-releases of cuml-cu12
specifically, but not necessarily its dependencies".
pip install 'cuml-cu12==24.8.*,>=0.0.0a0'
There's some more discussion on this in https://peps.python.org/pep-0440/#handling-of-pre-releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably update https://github.com/rapidsai/build-planning/blob/main/docs/docs/packaging.md#nightlies (and then use it as a reference).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're totally right, I keep forgetting about those docs. I'll put up a PR there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/merge |
Description
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89
Proposes introducing
rapids-build-backend
as this project's build backend, to reduce the complexity of various CI/build scripts.Checklist