chore(refactor): update pre-commit hook verions, pyupgrade target Python version #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
jameslamb
force-pushed
the
pyupgrade-config
branch
from
e609b4c
to
cedc33e
Compare
jameslamb
changed the title
|
CI here will be fixed by #107 |
bdice
approved these changes
Sep 16, 2024
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project supports
python>=3.9dependency-file-generator/pyproject.toml
Line 21 in 4e32ded
But is telling
pyupgradeit supportspython>=3.8.dependency-file-generator/.pre-commit-config.yaml
Lines 22 to 25 in 4e32ded
This fixes that, and updates all the other hook versions (
pre-commit autoupdate) since it's been a while.Notes for Reviewers
Shouldn't we upgrade the floor to
requires-python = >= 3.10?I don't think so. That's being done across RAPIDS libraries in rapidsai/build-planning#88 right now, but
rapids-dependency-file-generatoris used in many places outside of RAPIDS (see everything linked to #89, for example).For tools like this, I think we should generally support a wider range of Python versions than RAPIDS itself does.