introduce libcuml wheels#6199
introduce libcuml wheels#6199rapids-bot[bot] merged 77 commits intorapidsai:branch-25.02from jameslamb:libcuml-wheels
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
On this PR, I see:
Those times do not include time spent waiting for a runner to pick up the jobs... that's all time occupying a GPU runner. I see that happening on other PRs too, for example this in-progress build from #6238: https://github.com/rapidsai/cuml/actions/runs/12931830455/job/36069533961 Not sure if #6247 is the root cause... that refers to a "hang" but doesn't have other details. |
Contributes to rapidsai/build-planning#33 Adjusts `rapids-build-utils` manifest for release 25.02 to account for the introduction of new `libcuml` wheels (rapidsai/cuml#6199). ## Notes for Reviewers This shouldn't be merged still pointing at my forks. Plan: 1. merge #440, then update this branch 2. see CI pass here 3. see all CI except devcontainers pass on rapidsai/cuml#6199 4. point this PR back at upstream and admin-merge it 5. re-run devcontainers CI on rapidsai/cuml#6199 and see it pass
|
Sweet everything is finally passing here! |
I think this is ready! |
|
/merge |
Proposes updating the metadata here to account for new wheels added in the 25.02 release cycle. This shouldn't be merged until all of these are: * [x] `libcugraph` (rapidsai/cugraph#4804) * [x] `libcuml` (rapidsai/cuml#6199 ) * [x] `libcuvs` (rapidsai/cuvs#594)
Replaces #6006, contributes to rapidsai/build-planning#33.
Proposes packaging
libcumlas a wheel, which is then re-used bycuml-cu{11,12}wheels.Notes for Reviewers
Benefits of these changes
Wheel contents
libcuml:libcuml++.so(shared library) and its headerslibcumlprims_mg.so(shared library) and its headersfmt)cuml:cumlPython / Cython code and compiled Cython extensionsDependency Flows
In short....
libcumlcontainslibcuml.soandlibcumlprims_mg.sodynamic libraries and the headers to link against them.libcugraphwheels as a build dependency.libcuml.load_library().For more details and some flowcharts, see rapidsai/build-planning#33 (comment)
Size changes (CUDA 12, Python 3.12, x86_64)
libcumlcumlNOTES: size = compressed, "before" = 2025-01-22 nightlies
how I calculated those (click me)
docker run \ --rm \ --network host \ --env RAPIDS_NIGHTLY_DATE=2025-01-22 \ --env CUML_NIGHTLY_SHA=01e19bba9821954b062a04fbf31d3522afa4b0b1 \ --env CUML_PR="pull-request/6199" \ --env CUML_PR_SHA="9d5100ec4589e20230a31817518427efa1e49c6d" \ --env RAPIDS_PY_CUDA_SUFFIX=cu12 \ --env WHEEL_DIR_BEFORE=/tmp/wheels-before \ --env WHEEL_DIR_AFTER=/tmp/wheels-after \ -it rapidsai/ci-wheel:cuda12.5.1-rockylinux8-py3.12 \ bash # --- nightly wheels --- # mkdir -p ./wheels-before export RAPIDS_BUILD_TYPE=branch export RAPIDS_REF_NAME="branch-25.02" # cuml RAPIDS_PY_WHEEL_NAME="cuml_${RAPIDS_PY_CUDA_SUFFIX}" \ RAPIDS_REPOSITORY=rapidsai/cuml \ RAPIDS_SHA=${CUML_NIGHTLY_SHA} \ rapids-download-wheels-from-s3 python ./wheels-before # --- wheels from CI --- # mkdir -p ./wheels-after export RAPIDS_BUILD_TYPE="pull-request" # libcuml RAPIDS_PY_WHEEL_NAME="libcuml_${RAPIDS_PY_CUDA_SUFFIX}" \ RAPIDS_REPOSITORY=rapidsai/cuml \ RAPIDS_REF_NAME="${CUML_PR}" \ RAPIDS_SHA="${CUML_PR_SHA}" \ rapids-download-wheels-from-s3 cpp ./wheels-after # cuml RAPIDS_PY_WHEEL_NAME="cuml_${RAPIDS_PY_CUDA_SUFFIX}" \ RAPIDS_REPOSITORY=rapidsai/cuml \ RAPIDS_REF_NAME="${CUML_PR}" \ RAPIDS_SHA="${CUML_PR_SHA}" \ rapids-download-wheels-from-s3 python ./wheels-after pip install pydistcheck pydistcheck \ --inspect \ --select 'distro-too-large-compressed' \ ./wheels-before/*.whl \ | grep -E '^checking|files: | compressed' \ > ./before.txt # get more exact sizes du -sh ./wheels-before/* pydistcheck \ --inspect \ --select 'distro-too-large-compressed' \ ./wheels-after/*.whl \ | grep -E '^checking|files: | compressed' \ > ./after.txt # get more exact sizes du -sh ./wheels-after/*How I tested this
These other PRs: