Skip to content

Normalize whitespace#6238

Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.02from
bdice:trim-whitespace
Jan 23, 2025
Merged

Normalize whitespace#6238
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.02from
bdice:trim-whitespace

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Jan 20, 2025

This PR applies pre-commit hooks to normalize whitespace (trimming trailing whitespace and enforcing consistent end-of-file newlines).

These rules are already applied to most other RAPIDS repos, so this PR aligns with the norm in RAPIDS.

@bdice bdice requested review from a team as code owners January 20, 2025 20:23
@bdice bdice requested review from AyodeAwe, cjnolet and vyasr January 20, 2025 20:23
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bdice bdice self-assigned this Jan 20, 2025
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 20, 2025
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed the changes and they all look safe, so I'm approving assuming that all the failures are due to the upstream issues blocking cuml CI.

@bdice bdice removed the request for review from cjnolet January 22, 2025 16:22
@bdice
Copy link
Contributor Author

bdice commented Jan 23, 2025

/merge

@bdice
Copy link
Contributor Author

bdice commented Jan 23, 2025

/merge

@rapids-bot rapids-bot bot merged commit 1bcd5c7 into rapidsai:branch-25.02 Jan 23, 2025
64 of 65 checks passed
@bdice
Copy link
Contributor Author

bdice commented Jan 23, 2025

An optional job failed with:

FAILED test_kmeans.py::test_fit_transform_weighted_kmeans[10-5-25-100] - assert (-2425.780517578125 - -14697.736328125) <= (1.0 * 1.5)

https://github.com/rapidsai/cuml/actions/runs/12931830455/job/36069531183?pr=6238#step:8:6714

Just noting that in case it happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CMake CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants