Skip to content

add new C++ wheels: libcuvs, libcugraph, libcuml#40

Merged
jameslamb merged 4 commits intorapidsai:mainfrom
jameslamb:new-cpp-wheels
Jan 24, 2025
Merged

add new C++ wheels: libcuvs, libcugraph, libcuml#40
jameslamb merged 4 commits intorapidsai:mainfrom
jameslamb:new-cpp-wheels

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 23, 2025

Proposes updating the metadata here to account for new wheels added in the 25.02 release cycle.

This shouldn't be merged until all of these are:

@jameslamb jameslamb added DO NOT MERGE Hold off on merging; see PR for details improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 23, 2025
@jameslamb jameslamb changed the title WIP: add new C++ wheels: libraft, libcuvs, libcugraph add new C++ wheels: libraft, libcuvs, libcugraph Jan 24, 2025
@jameslamb jameslamb marked this pull request as ready for review January 24, 2025 15:46
@jameslamb jameslamb requested a review from a team as a code owner January 24, 2025 15:46
@jameslamb jameslamb requested a review from gforsyth January 24, 2025 15:46
@jameslamb jameslamb mentioned this pull request Jan 24, 2025
Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- I don't see anywhere else that wheel availability needs to be flagged.

@jameslamb jameslamb changed the title add new C++ wheels: libraft, libcuvs, libcugraph add new C++ wheels: libcuvs, libcugraph, libcuml, libraft Jan 24, 2025
@jameslamb jameslamb changed the title add new C++ wheels: libcuvs, libcugraph, libcuml, libraft add new C++ wheels: libcuvs, libcugraph, libcuml Jan 24, 2025
Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving -- do we want to add the cuml links back to the top-level post so they get included in the commit message?

@gforsyth
Copy link
Contributor

re-approving -- do we want to add the cuml links back to the top-level post so they get included in the commit message?

ignore me, just saw they're already there

@jameslamb
Copy link
Member Author

Thanks for being thorough @gforsyth , yep I juuuuust added them.

@jameslamb jameslamb merged commit cc36730 into rapidsai:main Jan 24, 2025
7 checks passed
@jameslamb jameslamb deleted the new-cpp-wheels branch January 24, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Hold off on merging; see PR for details improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants