Ensure all method signatures are sklearn compatible#6260
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.02from Jan 27, 2025
Merged
Ensure all method signatures are sklearn compatible#6260rapids-bot[bot] merged 3 commits intorapidsai:branch-25.02from
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.02from
Conversation
`sklearn` requires `fit`/`fit_transform`/... always take a `y` parameter, even if it's ignored. This adds a test to ensure our signatures match this rule, and fixes any cases where they didn't. This makes it easier to include `cuml` estimators within sklearn pipelines.
jcrist
added
bug
wphicks
approved these changes
Jan 24, 2025
Contributor
wphicks
left a comment
wphicks
left a comment
There was a problem hiding this comment.
Love anything that gets us closer to API compatibility! Nice change and solid implementation.
Member
Author
|
Failures look unrelated (and maybe transient). I lack permissions to restart the failed runs. |
Contributor
betatim
approved these changes
Jan 27, 2025
Member
|
Merged "main" into this PR to get the changes from #6227 which will solve the failed CI runs |
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sklearnrequiresfit/fit_transform/... always take ayparameter, even if it's ignored. This adds a test to ensure our signatures match this rule, and fixes any cases where they didn't. This makes it easier to includecumlestimators within sklearn pipelines.Fixes #6255.