build and test against CUDA 13.1.0#5383
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Builds are failing like this: Something similar's happening in cuML: rapidsai/cuml#7650 (comment) The root cause is probably rapidsai/raft#2916 |
|
Just noting this for visibility (James already knows this), we likely first need PR: rapidsai/cuvs#1686 |
|
pip devcontainer builds (but only pip devcontainers, not conda or wheels or conda devcontainers) are failing like this:
Probably a bit more fallout from these changes:
I'll try to fix that here. |
| CUDA::cusolver${_ctk_static_suffix} | ||
| CUDA::cusparse${_ctk_static_suffix} | ||
| PRIVATE | ||
| cuco::cuco |
There was a problem hiding this comment.
Similar to #5383 (comment)
FAILED: CMakeFiles/cugraph_etl.dir/src/renumbering.cu.o
/usr/bin/sccache /usr/local/cuda/bin/nvcc ...flags... -c /home/coder/cugraph/cpp/libcugraph_etl/src/renumbering.cu -o CMakeFiles/cugraph_etl.dir/src/renumbering.cu.o
In file included from /home/coder/cugraph/cpp/libcugraph_etl/build/pip/cuda-13.1/release/_deps/cudf-src/cpp/include/cudf/hashing/detail/default_hash.cuh:8,
from /home/coder/cugraph/cpp/libcugraph_etl/include/hash/concurrent_unordered_map.cuh:13,
from /home/coder/cugraph/cpp/libcugraph_etl/src/renumbering.cu:24:
/home/coder/cugraph/cpp/libcugraph_etl/build/pip/cuda-13.1/release/_deps/cudf-src/cpp/include/cudf/hashing/detail/murmurhash3_x86_32.cuh:16:10: fatal error: cuco/hash_functions.cuh: No such file or directory
16 | #include <cuco/hash_functions.cuh>
| ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
libcugraph_etl needs to explicitly declare its usage of cuco::cuco, now that it's not getting it transitively from raft -> cugraph.
| option(BUILD_SHARED_LIBS "Build cuGraph shared libraries" ON) | ||
| option(BUILD_CUGRAPH_ETL_MG_TESTS "Build cuGraph multigpu algorithm tests" OFF) | ||
| option(CMAKE_CUDA_LINEINFO "Enable the -lineinfo option for nvcc (useful for cuda-memcheck / profiler" OFF) | ||
| option(CMAKE_CUDA_LINEINFO "Enable the -lineinfo option for nvcc (useful for cuda-memcheck / profiler)" OFF) |
There was a problem hiding this comment.
Just noticed while looking at this file, seems non-controversial 😅
|
Style checks were blocking (missed a copyright year update). I pushed a fix and triggered CI. |
|
Since this will need a rebuild anyway, I cancelled CI to free up some CI resources for the all-of-RAPIDS rebuild happening at https://github.com/rapidsai/workflows/actions/runs/20937345532/job/60163076795 |
|
/ok to test |
I'm seeing this failure in the CI. I don't know if this is related but I saw a similar error during CCCL 3.2 bringup and fixed an out-of-bounds memory access in this test in #5375. Just mentioning in case it helps with finding a solution. |
|
Thanks! I'll also try re-running the wheel test jobs that timed out after 6 hours. I'll put this up for review and go ask for some help from cuGraph folks. |
|
It looks like those same C++ test failures happened on the latest nightly run: https://github.com/rapidsai/cugraph/actions/runs/20947945296/job/60194614337 So probably not related to the changes in this PR. |
|
/merge |
|
Admin-merging, based on offline conversation with @bdice @rlratzel @seunghwak , to unblock at least C++ / devcontainers CI. |
Contributes to rapidsai/build-planning#236
Tests that CI here will work with the changes from rapidsai/shared-workflows#483,
switches CUDA 13 builds to CUDA 13.1.0 and adds some CUDA 13.1.0 test jobs.