Avoid modifying a std::move-ed out object#5395
Closed
seunghwak wants to merge 4 commits intorapidsai:mainfrom
Closed
Avoid modifying a std::move-ed out object#5395seunghwak wants to merge 4 commits intorapidsai:mainfrom
seunghwak wants to merge 4 commits intorapidsai:mainfrom
Conversation
bdice
reviewed
Jan 13, 2026
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Contributor
Author
|
#5383 includes this fix, just closing the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying a std::move-ed out object is an undefined behavior. To re-use the move-ed out object, it should be re-initialized. We may pull these updates to #5383 and just close this PR.