add devcontainers#79
add devcontainers#79rapids-bot[bot] merged 10 commits intorapidsai:branch-25.02from jameslamb:add-devcontainers
Conversation
|
Think this will need rapidsai/devcontainers#423 before it can pass. |
| packages: | ||
| - &cmake_ver cmake>=3.26.4,!=3.30.0 | ||
| - ninja | ||
| specific: |
There was a problem hiding this comment.
Copied this compiler block directly from cugraph: https://github.com/rapidsai/cugraph/blob/3d681cc9e6d85336822ccb6faf0d1cba5f759ead/dependencies.yaml#L304-L330
To try to fix this error in the conda devcontainer build:
CMake Error at /home/coder/.conda/envs/rapids/share/cmake-3.31/Modules/CMakeDetermineCXXCompiler.cmake:48 (message):
Could not find compiler set in environment variable CXX:
/usr/bin/g++.
Call Stack (most recent call first):
CMakeLists.txt:39 (project)
Most other RAPIDS repos I checked have something like this, and I found offline conversations where it was suggested that the conda devcontainer builds expect the conda environment to provide compilers.
bdice
left a comment
There was a problem hiding this comment.
One question about ucx versions. Otherwise approved.
| "args": { | ||
| "CUDA": "11.8", | ||
| "PYTHON_PACKAGE_MANAGER": "pip", | ||
| "BASE": "rapidsai/devcontainers:25.02-cpp-cuda11.8-ucx1.15.0-openmpi-ubuntu22.04" |
There was a problem hiding this comment.
This uses ucx 1.15 but the CUDA 12 container uses ucx 1.17. Is that right?
There was a problem hiding this comment.
That's a great catch! I think it should be 1.17 here too.
I copied these directly from cugraph, looks like that was an oversight in rapidsai/cugraph#4562 (comment).
Let's try 1.17 here.
There was a problem hiding this comment.
We need to fix this in cugraph and nx-cugraph. https://github.com/search?q=org%3Arapidsai%20ucx1.15&type=code
There was a problem hiding this comment.
I agree. I'll do that alongside this other UCX-related devcontainers change I'm about to go make: rapidsai/devcontainers#421 (comment)
There was a problem hiding this comment.
I just pushed a commit adding those changes (setting RAPIDS_LIBUCX_PREFER_SYSTEM_LIBRARY=true in the pip devcontainers) here.
And manually cancelled CI because it'll fail until rapidsai/raft#2513 is done.
| packages: | ||
| - &cmake_ver cmake>=3.26.4,!=3.30.0 | ||
| - ninja | ||
| specific: |
|
wholegraph wheel builds are failing like this: I think that's a result of the ongoing logging changes, and should be fixed by rapidsai/raft#2513. |
… references (#53) Contributes to rapidsai/build-planning#118 Proposes the following changes for pip devcontainers: * use UCX 1.17 (ref: rapidsai/cugraph-gnn#79 (comment)) * prefer system installation of ucx to the one provided by the `libucx-cu{11,12}` wheels (ref: rapidsai/devcontainers#421 (comment)) And some other related changes noticed while doing that: * update lingering `24.*` references to `25.02` * fix `update-version.sh` so those will be correctly updated in future releases Similar to rapidsai/cugraph#4792 ## Notes for Reviewers ### How I tested this Relying on CI for most things. But for `update-version.sh`, tested like this: ```shell ./ci/release/update-version.sh '25.02.00' git grep -E '24\.' ``` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #53
Contributes to rapidsai/build-planning#118 Proposes the following changes for pip devcontainers: * use UCX 1.17 (ref: rapidsai/cugraph-gnn#79 (comment)) * prefer system installation of ucx to the one provided by the `libucx-cu{11,12}` wheels (ref: rapidsai/devcontainers#421 (comment)) And one other related change: * skip most CI when a PR only changes files in the `.devcontainer/` directory (this was incorrectly spelled `.devcontainers/` before) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #4792
|
/merge |
Follow-up to these PRs:
Proposes adding devcontainers and a devcontainers CI job to the repo.
Notes for Reviewers
Benefits of these changes
Similar to rapidsai/nx-cugraph#25
How I made these changes
Copied the
.devcontainer/directory from https://github.com/rapidsai/cugraph, then just changedcugraphreferences tocugraph-gnn.How I tested this
Tested the
update-version.shchanges like this: