add devcontainers#25
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-24.12from Nov 20, 2024
jameslamb:add-devcontainers
Merged
add devcontainers#25rapids-bot[bot] merged 3 commits intorapidsai:branch-24.12from jameslamb:add-devcontainers
rapids-bot[bot] merged 3 commits intorapidsai:branch-24.12from
jameslamb:add-devcontainers
Conversation
jameslamb
added
improvement
Member
Author
|
Cancelled CI to save those resources for other projects. @eriknw , restart CI here once rapidsai/devcontainers#417 or rapidsai/devcontainers#418 is merged. |
eriknw
approved these changes
Nov 15, 2024
Contributor
eriknw
left a comment
eriknw
left a comment
There was a problem hiding this comment.
LGTM insofar as I can tell 👍
nv-rliu
approved these changes
Nov 18, 2024
Contributor
|
Merging now that rapidsai/devcontainers#417 and rapidsai/devcontainers#418 have been merged. |
Contributor
|
/merge |
bdice
approved these changes
Nov 20, 2024
rapids-bot bot
pushed a commit
to rapidsai/cugraph-gnn
that referenced
this pull request
Dec 3, 2024
Follow-up to these PRs: * rapidsai/devcontainers#417 * #68 Proposes adding devcontainers and a devcontainers CI job to the repo. ## Notes for Reviewers ### Benefits of these changes * faster and easier local development * reduced risk of changes here breaking the RAPIDS unified devcontainers maintained in https://github.com/rapidsai/devcontainers Similar to rapidsai/nx-cugraph#25 ### How I made these changes Copied the `.devcontainer/` directory from https://github.com/rapidsai/cugraph, then just changed `cugraph` references to `cugraph-gnn`. ### How I tested this Tested the `update-version.sh` changes like this: ```shell ./ci/release/update-version.sh '25.04.00' git grep -E '25\.[0-9]+' ``` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds devcontainers and devcontainer CI jobs.
Notes for Reviewers
I created this by copying from the
cugraphrepo and then just changing all the references tonx-cugraph(and removing a few unnecessary things, like details about cloning cugraph-ops).This will be blocked until rapidsai/devcontainers#417 or rapidsai/devcontainers#418 is merged.