prefer system installs of UCX libraries when using RAPIDS wheels#421
Merged
trxcllnt merged 3 commits intorapidsai:branch-24.12from Nov 27, 2024
jameslamb:ucx-libraries
Merged
prefer system installs of UCX libraries when using RAPIDS wheels#421trxcllnt merged 3 commits intorapidsai:branch-24.12from jameslamb:ucx-libraries
trxcllnt merged 3 commits intorapidsai:branch-24.12from
jameslamb:ucx-libraries
Conversation
Contributor
|
@trxcllnt does this look fine to you? |
trxcllnt
requested changes
Nov 18, 2024
Collaborator
trxcllnt
left a comment
trxcllnt
left a comment
There was a problem hiding this comment.
Can we put this envvar in the pip section of the respective devcontainers' Dockerfiles?
Member
Author
trxcllnt
approved these changes
Nov 27, 2024
Collaborator
|
LGTM. This covers the combined devcontainer in this repo, but we should also add this to any repos that use UCX in their pip devcontainers. |
Member
Author
|
Alright thanks for pointing that out! I can do that. Added a note in rapidsai/build-planning#118 |
This was referenced Nov 27, 2024
Member
Author
put up PRs for all of those:
|
rapids-bot bot
pushed a commit
to rapidsai/nx-cugraph
that referenced
this pull request
Dec 2, 2024
… references (#53) Contributes to rapidsai/build-planning#118 Proposes the following changes for pip devcontainers: * use UCX 1.17 (ref: rapidsai/cugraph-gnn#79 (comment)) * prefer system installation of ucx to the one provided by the `libucx-cu{11,12}` wheels (ref: rapidsai/devcontainers#421 (comment)) And some other related changes noticed while doing that: * update lingering `24.*` references to `25.02` * fix `update-version.sh` so those will be correctly updated in future releases Similar to rapidsai/cugraph#4792 ## Notes for Reviewers ### How I tested this Relying on CI for most things. But for `update-version.sh`, tested like this: ```shell ./ci/release/update-version.sh '25.02.00' git grep -E '24\.' ``` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #53
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Dec 2, 2024
Contributes to rapidsai/build-planning#118 Proposes the following changes for pip devcontainers: * prefer system installation of ucx to the one provided by the `libucx-cu{11,12}` wheels (ref: rapidsai/devcontainers#421 (comment)) And some other related changes noticed while doing that: * update lingering `24.*` references to `25.02` ## Notes for Reviewers ### How I tested this Relying on CI for most things. Double-checked that `update-version.sh` would have caught the one lingering `24.12` reference like this: ```shell ./ci/release/update-version.sh '25.02.00' git grep -E '24\.' ``` Similar to rapidsai/cuml#6149 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #501
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Dec 2, 2024
Contributes to rapidsai/build-planning#118 Proposes the following changes for pip devcontainers: * use UCX 1.17 (ref: rapidsai/cugraph-gnn#79 (comment)) * prefer system installation of ucx to the one provided by the `libucx-cu{11,12}` wheels (ref: rapidsai/devcontainers#421 (comment)) And one other related change: * skip most CI when a PR only changes files in the `.devcontainer/` directory (this was incorrectly spelled `.devcontainers/` before) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #4792
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Dec 4, 2024
… references (#2514) Contributes to rapidsai/build-planning#118 Proposes the following changes for pip devcontainers: * prefer system installation of ucx to the one provided by the `libucx-cu{11,12}` wheels (ref: rapidsai/devcontainers#421 (comment)) And some other related changes noticed while doing that: * update lingering `24.*` references to `25.02` ## Notes for Reviewers ### How I tested this Relying on CI for most things. Double-checked that `update-version.sh` would have caught the one lingering `24.12` reference like this: ```shell ./ci/release/update-version.sh '25.02.00' git grep -E '24\.' ``` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #2514
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Dec 11, 2024
…PIDS references (#6149) Contributes to rapidsai/build-planning#118 Proposes the following changes for pip devcontainers: * prefer system installation of ucx to the one provided by the `libucx-cu{11,12}` wheels (ref: rapidsai/devcontainers#421 (comment)) And some other related changes noticed while doing that: * update lingering `24.*` references to `25.02` ## Notes for Reviewers ### How I tested this Relying on CI for most things. Double-checked that `update-version.sh` would have caught the one lingering `24.12` reference like this: ```shell ./ci/release/update-version.sh '25.02.00' git grep -E '24\.' ``` Authors: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) Approvers: - Tim Head (https://github.com/betatim) - Bradley Dice (https://github.com/bdice) URL: #6149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#118
Should only be merged if / after we merge rapidsai/ucx-wheels#13. That PR switches
libucxwheels' loading behavior, such thatlibucx.load_library()(whichucx-pyandlibucxxcall at import time) prefers thelibuc{m,p,s}.soprovided by thelibucxwheels.rapidsai/ucx-wheels#13 introduces an environment variable to control that... this proposes setting that, to continue preferring system-installed UCX libraries in devcontainers.