Repository navigation
rocmPackages_10: add rocMLIR - #27
Closed
randomizedcoder wants to merge 1 commit into
Closed
randomizedcoder wants to merge 1 commit into
randomizedcoder wants to merge 1 commit into
Conversation
randomizedcoder
force-pushed
the
rocm10/10-rocmlir
branch
2 times, most recently
from
October 17, 2026 02:50
e621057 to
d31e13e
Compare
randomizedcoder
force-pushed
the
rocm10/09-composable-kernel
branch
from
October 17, 2026 16:20
16bee19 to
8148431
Compare
randomizedcoder
force-pushed
the
rocm10/10-rocmlir
branch
from
October 17, 2026 16:20
d31e13e to
7311e65
Compare
randomizedcoder
force-pushed
the
rocm10/09-composable-kernel
branch
from
October 20, 2026 06:44
8148431 to
ce6e3df
Compare
randomizedcoder
force-pushed
the
rocm10/10-rocmlir
branch
from
October 20, 2026 06:44
7311e65 to
0c1b2b9
Compare
randomizedcoder
force-pushed
the
rocm10/09-composable-kernel
branch
from
October 21, 2026 07:15
ce6e3df to
3af6d0c
Compare
randomizedcoder
force-pushed
the
rocm10/10-rocmlir
branch
from
October 21, 2026 07:15
0c1b2b9 to
2abe659
Compare
randomizedcoder
force-pushed
the
rocm10/09-composable-kernel
branch
from
October 22, 2026 14:51
3af6d0c to
ddf83e6
Compare
randomizedcoder
force-pushed
the
rocm10/10-rocmlir
branch
from
October 22, 2026 14:51
2abe659 to
369a039
Compare
rocmlirTriton is the fork of rocMLIR that AMDMIGraphX 10.1 pins (requirements.txt: ROCm/rocmlirTriton@release/rocm-rel-10.1, a branch; the repository has no tags). ROCm/rocMLIR has no ROCm 10 release, so rocmPackages_10 has no rocmlir; with aliases enabled, rocmlir and rocmlir-rock throw with that explanation. The expression starts from rocmPackages.rocmlir. From "rocmPackages.rocmlir: track rocmlirTriton for therock-10.1": ROCm 10.1's AMDMIGraphX (rocm-10.1) moved its rocMLIR pin to a new upstream repo: requirements.txt pins ROCm/rocmlirTriton@release/rocm-rel-10.1. It has no ROCm 10.x tag, so track the branch-head commit directly, as the old ROCm/rocMLIR pin did. Build fixes for the new source: - pybind11 for the Rock Python bindings' find_package(pybind11). - LLVM_TARGETS_TO_BUILD: append the native target unconditionally. Triton's librockcompiler_deps.cmake bundles host codegen (LLVMX86AsmParser/CodeGen/ Desc/Disassembler/Info) into the librockCompiler fat archive, which failed to link with AMDGPU-only. - MLIR_INCLUDE_TESTS=false: the check-rocmlir lit suite DEPENDS on ci-performance-scripts, a target only created when MLIR_ENABLE_ROCM_RUNNER is on (off for the rock-compiler build), so Generate failed. - preConfigure: give the build a writable HOME and TRITON_CACHE_PATH. Triton's build_helpers.py symlinks the in-tree LLVM into $HOME/.triton at configure time, which failed against the read-only /homeless-shelter. - postPatch: patchShebangs the whole external/llvm-project/mlir subtree and drop the BufferDependencyAnalysis.cpp enum-class fix (file no longer ships). Revised during the split review: Package it as rocmlir-triton instead of replacing rocmlir. Point the homepage at rocmlirTriton and remove the generic tag updater: the revision must move together with MIGraphX's pin. Assisted-by: Claude Code (claude-opus-5-5)
randomizedcoder
force-pushed
the
rocm10/09-composable-kernel
branch
from
October 27, 2026 04:12
ddf83e6 to
7068ad1
Compare
randomizedcoder
force-pushed
the
rocm10/10-rocmlir
branch
from
October 27, 2026 04:12
369a039 to
5623264
Compare
This was referenced Oct 27, 2026
Closed
Owner
Author
|
Opened upstream as NixOS#579523. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 10/14. Part of splitting upstream PR 573885 (
rocmPackages: 7.2.4 -> 10.1) into smaller PRs, as asked in its review.rocmPackages_10:rocmlir-triton(new)master. No existing derivation changes:rocmPackages_10is not recursed intoHow to review
rocm-modules/10/rocmlir-triton/, started from the 7.2.4 rocmlir expression; the reasons are in the commit messageNotes
release/rocm-rel-10.1head (f347064fea12), the commit MIGraphX'srocm-10.1requirements.txt pinsrocmlir:rocmlirandrocmlir-rockthrow with an explanation, and the release notes say soTesting
rocmPackages_10evaluates: 59 derivations, 0 failuresSeries
Preparatory PRs, each against
master: #10, #11, #15, #16, #17.master🤖 Generated with Claude Code