Repository navigation
rocmPackages_10: add composable_kernel - #26
Closed
randomizedcoder wants to merge 2 commits into
Closed
randomizedcoder wants to merge 2 commits into
randomizedcoder wants to merge 2 commits into
Conversation
randomizedcoder
force-pushed
the
rocm10/09-composable-kernel
branch
from
October 15, 2026 23:02
c632c92 to
5d3ae80
Compare
randomizedcoder
force-pushed
the
rocm10/08-sparse-solvers
branch
2 times, most recently
from
October 17, 2026 02:50
44f8a64 to
235026f
Compare
randomizedcoder
force-pushed
the
rocm10/09-composable-kernel
branch
2 times, most recently
from
October 17, 2026 16:20
16bee19 to
8148431
Compare
randomizedcoder
force-pushed
the
rocm10/08-sparse-solvers
branch
from
October 20, 2026 06:44
0914857 to
970adf2
Compare
randomizedcoder
force-pushed
the
rocm10/09-composable-kernel
branch
from
October 20, 2026 06:44
8148431 to
ce6e3df
Compare
randomizedcoder
force-pushed
the
rocm10/08-sparse-solvers
branch
from
October 21, 2026 07:15
970adf2 to
d05854b
Compare
randomizedcoder
force-pushed
the
rocm10/09-composable-kernel
branch
2 times, most recently
from
October 22, 2026 14:51
3af6d0c to
ddf83e6
Compare
randomizedcoder
force-pushed
the
rocm10/08-sparse-solvers
branch
from
October 22, 2026 14:51
d05854b to
6a96f46
Compare
Verbatim copies of the rocmPackages (ROCm 7.2.4) expressions for composable_kernel, not yet part of the rocmPackages_10 scope. The following commits update each one to ROCm 10.1, so their diffs read against 7.2.4. Assisted-by: Claude Code (claude-opus-5-5)
Update the rocmPackages.composable_kernel copy from the previous commit to ROCm 10.1 and add it to the rocmPackages_10 scope. From "rocmPackages.composable_kernel: adapt to ROCm 10 conv targets and clang 24": ROCm 10 restructured CK's per-op conv instance libraries into OBJECT libraries aggregated under a single STATIC target device_conv_operations. clang 24 forwards NIX_LDFLAGS to the HIP device linker, so every split "parts" instance's device object is stamped with DT_RUNPATH=$out/lib. That RUNPATH is baked into the --offload-compress'd .hip_fatbin (a CCOB integrity-checked blob that cannot be scrubbed post-hoc without corrupting the device code), and since those .o are copied into the final CK derivation it becomes a disallowed cross-reference. The parts only emit relocatable .o, so the self-rpath is useless here; strip "-rpath $out/lib" from NIX_LDFLAGS (and any role-suffixed copies) in preConfigure, keeping offload compression. Also give fix-empty-offload-targets.diff a gfx90a fallback for an empty offload-target list. Revised during the split review: Restore memory-bounded per-group parts for the convolution instances, using ROCm 10's layout-specific OBJECT targets; the final build only archives their objects into device_conv_operations. Parts skip targets CMake did not generate for the configuration and fail on names the CK source no longer defines. Drop the streamk targets, removed upstream. Assisted-by: Claude Code (claude-opus-5-5)
randomizedcoder
force-pushed
the
rocm10/09-composable-kernel
branch
from
October 27, 2026 04:12
ddf83e6 to
7068ad1
Compare
This was referenced Oct 27, 2026
Closed
Owner
Author
|
Opened upstream as NixOS#579522. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 9/14. Part of splitting upstream PR 573885 (
rocmPackages: 7.2.4 -> 10.1) into smaller PRs, as asked in its review.rocmPackages_10:composable_kernelmaster. No existing derivation changes:rocmPackages_10is not recursed intoHow to review
rocm-modules/10/Notes
device_conv_operationsTesting
rocmPackages_10evaluates: 58 derivations, 0 failuresSeries
Preparatory PRs, each against
master: #10, #11, #15, #16, #17.master🤖 Generated with Claude Code