Repository navigation
rocmPackages_10: add sparse, solvers, rocALUTION, rocWMMA, hipfort - #25
Closed
randomizedcoder wants to merge 10 commits into
Closed
randomizedcoder wants to merge 10 commits into
randomizedcoder wants to merge 10 commits into
Conversation
randomizedcoder
force-pushed
the
rocm10/07-tensile-rocblas
branch
from
October 15, 2026 23:02
0f84a57 to
6b000b8
Compare
randomizedcoder
force-pushed
the
rocm10/08-sparse-solvers
branch
from
October 15, 2026 23:02
0b53be7 to
44f8a64
Compare
randomizedcoder
force-pushed
the
rocm10/07-tensile-rocblas
branch
from
October 17, 2026 02:50
6b000b8 to
6b95357
Compare
randomizedcoder
force-pushed
the
rocm10/08-sparse-solvers
branch
from
October 17, 2026 02:50
44f8a64 to
235026f
Compare
randomizedcoder
force-pushed
the
rocm10/07-tensile-rocblas
branch
from
October 17, 2026 16:20
6b95357 to
c37927f
Compare
randomizedcoder
force-pushed
the
rocm10/08-sparse-solvers
branch
from
October 17, 2026 16:20
235026f to
0914857
Compare
randomizedcoder
force-pushed
the
rocm10/07-tensile-rocblas
branch
from
October 20, 2026 06:44
c37927f to
e278b88
Compare
randomizedcoder
force-pushed
the
rocm10/08-sparse-solvers
branch
2 times, most recently
from
October 21, 2026 07:15
970adf2 to
d05854b
Compare
randomizedcoder
force-pushed
the
rocm10/07-tensile-rocblas
branch
2 times, most recently
from
October 22, 2026 14:51
c13eb13 to
e268c5f
Compare
randomizedcoder
force-pushed
the
rocm10/08-sparse-solvers
branch
from
October 22, 2026 14:51
d05854b to
6a96f46
Compare
Verbatim copies of the rocmPackages (ROCm 7.2.4) expressions for rocsparse, hipsparse, rocsolver, hipblas, hipsolver, rocalution, rocwmma, hipfort, hipsparselt, not yet part of the rocmPackages_10 scope. The following commits update each one to ROCm 10.1, so their diffs read against 7.2.4. Assisted-by: Claude Code (claude-opus-5-5)
Update the rocmPackages.rocsparse copy from the previous commit to ROCm 10.1 and add it to the rocmPackages_10 scope. Source/version bump only. Assisted-by: Claude Code (claude-opus-5-5)
Update the rocmPackages.hipsparse copy from the previous commit to ROCm 10.1 and add it to the rocmPackages_10 scope. From the mass bump: - hipblas, hipsparse: new find_package(Python3 REQUIRED) -> add python3. Assisted-by: Claude Code (claude-opus-5-5)
Update the rocmPackages.rocsolver copy from the previous commit to ROCm
10.1 and add it to the rocmPackages_10 scope.
From "rocmPackages.{hipsolver,rocsolver}: link openblas-backed LAPACK":
ROCm 10 hipSOLVER/rocSOLVER link a CPU-side BLAS/LAPACK. Upstream
defaults to git-clone+build a static OpenBLAS at configure (blocked in
the sandbox), so set HIPSOLVER_INTERNAL_LAPACK_BUILD=OFF and provide the
openblas-backed 'blas'/'lapack' wrappers (LP64). Deliberately NOT
lapack-reference: its libblas.so.3 carries ILP64 (_64_) symbols that
collide with numpy's openblas in one process (e.g. 'import torch' ->
undefined symbol cherk_64_). Discover LAPACK in CMake MODULE mode, since
the openblas wrappers ship no LAPACKConfig.cmake.
Assisted-by: Claude Code (claude-opus-5-5)
Update the rocmPackages.hipblas copy from the previous commit to ROCm 10.1 and add it to the rocmPackages_10 scope. From the mass bump: - hipblas, hipsparse: new find_package(Python3 REQUIRED) -> add python3. Assisted-by: Claude Code (claude-opus-5-5)
Update the rocmPackages.hipsolver copy from the previous commit to ROCm
10.1 and add it to the rocmPackages_10 scope.
From "rocmPackages.{hipsolver,rocsolver}: link openblas-backed LAPACK":
ROCm 10 hipSOLVER/rocSOLVER link a CPU-side BLAS/LAPACK. Upstream
defaults to git-clone+build a static OpenBLAS at configure (blocked in
the sandbox), so set HIPSOLVER_INTERNAL_LAPACK_BUILD=OFF and provide the
openblas-backed 'blas'/'lapack' wrappers (LP64). Deliberately NOT
lapack-reference: its libblas.so.3 carries ILP64 (_64_) symbols that
collide with numpy's openblas in one process (e.g. 'import torch' ->
undefined symbol cherk_64_). Discover LAPACK in CMake MODULE mode, since
the openblas wrappers ship no LAPACKConfig.cmake.
Assisted-by: Claude Code (claude-opus-5-5)
Update the rocmPackages.rocalution copy from the previous commit to ROCm 10.1 and add it to the rocmPackages_10 scope. From the mass bump: - rocalution, rpp: moved into the rocm-libraries monorepo (sparse Assisted-by: Claude Code (claude-opus-5-5)
Update the rocmPackages.rocwmma copy from the previous commit to ROCm 10.1 and add it to the rocmPackages_10 scope. From "rocmPackages.rocwmma: rocm_smi -> amd_smi, system googletest": ROCm 10 rocWMMA's benchmark tests find_package(amd_smi) (was rocm_smi) and replaced the hardcoded FetchContent(googletest) with a ROCWMMA_USE_SYSTEM_GOOGLETEST option. Switch to amdsmi, enable the system-gtest option, and drop the obsolete 0000-dont-fetch-googletest.patch. Assisted-by: Claude Code (claude-opus-5-5)
Update the rocmPackages.hipfort copy from the previous commit to ROCm 10.1 and add it to the rocmPackages_10 scope. From "rocmPackages.hipfort: 7.2.4 -> 10.1.0": hipfort keeps the three-component rocm-X.Y.Z tag scheme (rocm-10.1.0), so it is not derived from the therock-X.Y monorepo tags like the rest of the set. hipfort 10.x dropped the bin/ wrapper scripts (hipfc, mymcpu) entirely and is now a pure Fortran interface library, so the obsolete bin/ postPatch and meta.mainProgram are removed. Assisted-by: Claude Code (claude-opus-5-5)
Update the rocmPackages.hipsparselt copy from the previous commit to ROCm 10.1 and add it to the rocmPackages_10 scope. From "rocmPackages.hipsparselt: add hipblaslt device-library/stinkytofu sources": ROCm 10 hipsparselt configures hipBLASLt's CMakeLists (for rocisa), which needs library/include/hipblaslt-version.h.in and add_subdirectory's shared/stinkytofu. Extend the sparse checkout. Revised during the split review: Drop the stinkytofu clang-tidy workaround: therock-10.1 guards its include(ClangTidy) with ENABLE_CLANG_TIDY. Drop the HOME override; disabling the helper cache is enough, as hipBLASLt shows. Assisted-by: Claude Code (claude-opus-5-5)
randomizedcoder
force-pushed
the
rocm10/07-tensile-rocblas
branch
from
October 27, 2026 04:12
e268c5f to
c0ec6f6
Compare
randomizedcoder
force-pushed
the
rocm10/08-sparse-solvers
branch
from
October 27, 2026 04:12
6a96f46 to
3988705
Compare
This was referenced Oct 27, 2026
Closed
This was referenced Oct 27, 2026
Owner
Author
|
Opened upstream as NixOS#579521. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 8/14. Part of splitting upstream PR 573885 (
rocmPackages: 7.2.4 -> 10.1) into smaller PRs, as asked in its review.rocmPackages_10:rocsparse,hipsparse,rocsolver,hipblas,hipsolver,rocalution,rocwmma,hipfort,hipsparseltmaster. No existing derivation changes:rocmPackages_10is not recursed intoHow to review
rocm-modules/10/Notes
Testing
rocmPackages_10evaluates: 56 derivations, 0 failuresSeries
Preparatory PRs, each against
master: #10, #11, #15, #16, #17.master🤖 Generated with Claude Code