Repository navigation
rocmPackages.rocprof-trace-decoder: take comgr and runtime from scope - #17
Closed
randomizedcoder wants to merge 1 commit into
Closed
randomizedcoder wants to merge 1 commit into
randomizedcoder wants to merge 1 commit into
Conversation
randomizedcoder
force-pushed
the
rocm-prep/trace-decoder-scope
branch
from
October 17, 2026 02:50
ebf4d17 to
3b34528
Compare
randomizedcoder
changed the title
It took the top-level rocmPackages and used rocmPackages.rocm-comgr and rocmPackages.rocm-runtime, so the per-arch scopes (rocmPackages.gfx906, ...) and any other instance of the scope built it against the default set's libraries. Take them as scope arguments like every other package. The default rocmPackages.rocprof-trace-decoder derivation is unchanged. Assisted-by: Claude Code (claude-opus-5-5)
randomizedcoder
force-pushed
the
rocm-prep/trace-decoder-scope
branch
from
October 27, 2026 04:12
3b34528 to
7073e3e
Compare
This was referenced Oct 27, 2026
Closed
Owner
Author
|
Opened upstream as NixOS#579513. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting upstream PR 573885 (
rocmPackages: 7.2.4 -> 10.1) into smaller PRs, as asked in its review.rocprof-trace-decodertookrocm-comgrandrocm-runtimefrom the top-levelrocmPackagesrocmPackages.gfx906, …) androcmPackages_10built it against the default setrocmPackages.rocprof-trace-decoderderivation is unchangedTesting
🤖 Generated with Claude Code