Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump electron from 18.3.13 to 22.0.0 #3683

Closed
wants to merge 2 commits into from
Closed

Bump electron from 18.3.13 to 22.0.0 #3683

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 26, 2022 •
edited
Loading

Bumps electron from 18.3.13 to 22.0.0.

Release notes

Sourced from electron's releases.

electron v22.0.0

Release Notes for v22.0.0

Stack Upgrades

Breaking Changes

  • Added WebContents input-event event.
    • Deprecated BrowserWindow scroll-touch-* events. #35531
  • The deprecated new-window event has been removed. #34526

Features

  • Added LoadBrowserProcessSpecificV8Snapshot as a new fuse that will let the main/browser process load its v8 snapshot from a file at browser_v8_context_snapshot.bin. Any other process will use the same path as is used today. #35266 (Also in 20, 21)
  • Added WebContents.opener to access window opener.
    • Added webContents.fromFrame(frame) to get the WebContents corresponding to a WebFrameMain instance. #35140 (Also in 21)
  • Added app.getSystemLocale() method. #35697 (Also in 21)
  • Added contextBridge.exposeInIsolatedWorld(worldId, key, api) to expose an API to an isolatedWorld within a renderer from a preload script. #34974
  • Added webContents.close() method. #35509
  • Added webFrameMain.origin. #35438 (Also in 19, 20, 21)
  • Added an app.getPreferredSystemLanguages() API to return the user's system languages. #36291 (Also in 21)
  • Added new UtilityProcess API to launch chromium child process with node integration. #36089
  • Added new WebContents event content-bounds-updated. #35533
  • Added new WebContents.ipc and WebFrameMain.ipc APIs. #34959 (Also in 21)
  • Added support for Web Bluetooth pin pairing on Linux and Windows. #35416 (Also in 21)
  • Added support for navigator.mediaDevices.getDisplayMedia via a new session handler, ses.setDisplayMediaRequestHandler. #30702
  • Added support for serialPort.forget() as well as a new event serial-port-revoked emitted when a given origin is revoked. #36062

Fixes

  • Added support for Webauthn discoverable keys (aka resident keys), allowing users to authenticate without first having to select or type a username. #35374
  • Enable crashpad for ELECTRON_RUN_AS_NODE processes on linux. #36483
  • Fixed click event and tooltip of Tray not working on Linux. #36472
  • Fixed an issue where frameless non-resizable windows showed a Windows 7 frame during startup. #36024
  • Fixed an issue with incomplete EventEmitter object in sandboxed renderer preload script. #35522
  • Fixed race condition during update on macOS that could result in TCC and Keychain errors. #36362
  • Removed unneeded --turbo-profiling-input argument from mksnapshot_args. #36463

Also in earlier versions...

  • Added a background to the WCO container to avoid rendering glitches. #35569 (Also in 19, 20, 21)
  • Added support for Windows drop-down dialog extensions. #35618 (Also in 18, 19, 20, 21)
  • Default margin has been added in the code. #36073 (Also in 21)
  • Enable WCO maximize button when window enters tablet mode and is not already maximized. #35617 (Also in 19, 20, 21)
  • Fixed uv_os_gethostname failing on Windows 7. #35702 (Also in 19, 20, 21)

... (truncated)

Commits
  • 71941e7 chore: bump chromium to 108.0.5359.62 (22-x-y) (#36478)
  • 8d9a964 fix: enable crashpad for ELECTRON_RUN_AS_NODE processes (#36483)
  • e879e2f build(deps): bump minimatch from 3.0.4 to 3.0.8 (#36468)
  • 4989994 fix: reimplement Tray with StatusIconLinuxDbus on Linux (#36472)
  • ccc5a7a fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args… (#36463)
  • 6338350 chore: cherry-pick 7196a42b42ce from chromium (#36458)
  • 1601265 docs: add missing event-emitter link to utility-process docs (#36433)
  • 02eef17 chore: fix dangling promise in npm install (#36398)
  • 17d712e build: force ninja binary to the right arch after src cache restore (#36404)
  • 5085ac7 chore: bump chromium to 108.0.5359.48 (22-x-y) (#36388)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the component/dependencies Pull requests that update a dependency file label Dec 26, 2022
@gaktive gaktive requested a review from rak-phillip January 3, 2023 18:15
dependabot bot and others added 2 commits January 3, 2023 14:13
@dependabot @ericpromislow
Bump electron from 18.3.13 to 22.0.0
74f2c5f 
Bumps [electron](https://github.com/electron/electron) from 18.3.13 to 22.0.0.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v18.3.13...v22.0.0)

---
updated-dependencies:
- dependency-name: electron
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@ericpromislow
Temporarily use @inigolabs/ffi-napi to deal with v8 issues introduced…
cd176d5 
… in Electron 21

When ffi-napi is fixed, we can revert this change.

Signed-off-by: Eric Promislow <[email protected]>
@ericpromislow ericpromislow force-pushed the dependabot/npm_and_yarn/electron-22.0.0 branch from 71def05 to cd176d5 Compare January 3, 2023 22:22
@ericpromislow
Copy link
Contributor

I should have made a note when I first looked at this, but I recall the failure is due to a change in V8 JS runtime that isn't compatible with the FFI JS/C module.

nodejs/node-addon-api#1227

@ericpromislow ericpromislow requested a review from mook-as January 3, 2023 22:22
@ericpromislow
Copy link
Contributor

The patch on the bump works on macos and linux, but fails to build on Windows, because of a non-windows option PYTHON=python3 added to the install script in the module's package.json file.

The @inigolabs/ffi-napi doesn't seem to be in a github repo, but just code stored in npmjs.com, and I don't see bug issues or something similar there. The main contributor of this patch is also basically anonymous.

@gaktive gaktive marked this pull request as draft January 4, 2023 19:16
mook-as
mook-as requested changes Jan 9, 2023
View reviewed changes
package.json
@@ -64,6 +64,7 @@
"dompurify": "^2.3.10",
"electron-updater": "^5.2.1",
"express": "^4.18.1",
"@inigolabs/ffi-napi": "^4.0.10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the… opaqueness of this package, we should probably not use it. We may need to reconsider alternative ways to get the certificates (such as have a native executable that generates a tar file directly, instead of doing it from JS). :(

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 16, 2023

A newer version of electron exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@rak-phillip rak-phillip mentioned this pull request Jan 17, 2023
Closed
@jandubois jandubois mentioned this pull request Jul 8, 2023
Closed
15 tasks
@rak-phillip rak-phillip closed this Nov 2, 2023
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 2, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/electron-22.0.0 branch November 2, 2023 21:55
@rak-phillip
Copy link
Contributor

We updated to electron 26.2.4 in #5620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mook-as mook-as mook-as requested changes

@rak-phillip rak-phillip Awaiting requested review from rak-phillip

Assignees
No one assigned
Labels
component/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericpromislow @rak-phillip @mook-as