Bump Electron to version 26.2.4 #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rak-phillip
force-pushed
the
feature/5619-update-electron
branch
5 times, most recently
from
35ed59b to
4ad5599
Compare
rak-phillip
force-pushed
the
feature/5619-update-electron
branch
2 times, most recently
from
3d96f44 to
ecb04ce
Compare
rak-phillip
force-pushed
the
feature/5619-update-electron
branch
from
ecb04ce to
3606450
Compare
rak-phillip
changed the title
|
We won't merge this until after the 1.11 release, but I think that this PR is in a state that is ready to review. Please note that the required node version has been updated to 18.16.x and we might need to reinstall yarn depending on how you manage your node versions. |
mook-as
requested changes
Oct 5, 2023
rak-phillip
force-pushed
the
feature/5619-update-electron
branch
from
3606450 to
8dab896
Compare
mook-as
approved these changes
Oct 17, 2023
Specify a new minimum node version of >=18.16 Update node-version in github workflows Update node-version in cirrus workflows Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
After updating to Electron 26, it was found that dialogs would no longer auto resize properly. The additional flex container at the root of the dialog layout appeared to be causing issues allowing content to reflow in such a way that electron's `preferred-size-changed` event would not emit. Signed-off-by: Phillip Rak <[email protected]>
Older versions of electron had issues with zooming a `browserView` properly on macOS. Modifications that we previous made to allow for zooming are no longer required. Signed-off-by: Phillip Rak <[email protected]>
This resolves an error we were experiencing in the test ``` FetchError: request to http://localhost:6109/list failed, reason: connect ECONNREFUSED ::1:6109 ``` Node.js used to favor IPv4 but that changed in v17 > It's #39987 -- Node.js now returns IP addresses in the order they are returned from the name resolver/DNS. There's a --dns-result-order command line option you can set to control the behaviour -- the difference in Node.js 17 is the default changed. nodejs/node#40537 (comment) Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
rak-phillip
force-pushed
the
feature/5619-update-electron
branch
from
8dab896 to
a2b7b34
Compare
|
@mook-as rebased on top of main. Let me know if your approval still stands. If so, I intend to merge as soon as is conveniently possible 🙂 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps electron to 26.2.4 and node to version 18.16.x (the supported version of node for the 26.x release of electron 1)
In order to keep this change primarily focused on making sure that we can get Rancher Desktop running with a supported & stable version of Electron, we will need to follow up with additional PRs to complete the transition:
win-ca.tsin Go for Electron Sandboxing Compatibility #5637registerHttpProtocol®isterFileProtocolare deprecated by Electron #5659closes #5619
closes #5623
Footnotes
https://www.electronjs.org/docs/latest/tutorial/electron-timelines#timeline ↩