Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to electron 22 #3788

Closed
rak-phillip opened this issue Jan 17, 2023 · 1 comment
Closed

Upgrade to electron 22 #3788

rak-phillip opened this issue Jan 17, 2023 · 1 comment
Labels
component/dependencies Pull requests that update a dependency file component/ui kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API
Milestone

Comments

@rak-phillip
Copy link
Contributor

rak-phillip commented Jan 17, 2023

Upgrading to electron 22 works on macOS and Linux, but fails on Windows. We need to find an appropriate solution that that will allow us to continue updating electron.

The patch on the bump works on macos and linux, but fails to build on Windows, because of a non-windows option PYTHON=python3 added to the install script in the module's package.json file.

The @inigolabs/ffi-napi doesn't seem to be in a github repo, but just code stored in npmjs.com, and I don't see bug issues or something similar there. The main contributor of this patch is also basically anonymous.

Originally posted by @ericpromislow in #3683 (comment)

Given the… opaqueness of this package, we should probably not use it. We may need to reconsider alternative ways to get the certificates (such as have a native executable that generates a tar file directly, instead of doing it from JS). :(

Originally posted by @mook-as in #3683 (comment)

@rak-phillip rak-phillip added component/ui component/dependencies Pull requests that update a dependency file kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API labels Jan 17, 2023
@rak-phillip rak-phillip added this to the Later milestone Jan 17, 2023
@jandubois
Copy link
Member

We have already updated to Electron 26 in #5620, so I think this issue can be closed @rak-phillip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dependencies Pull requests that update a dependency file component/ui kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API
Projects
None yet
Development

No branches or pull requests

2 participants