Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron21.2.0 Calling native node crashes #1227

Closed
tangjianfang opened this issue Nov 2, 2022 · 5 comments
Closed

Electron21.2.0 Calling native node crashes #1227

tangjianfang opened this issue Nov 2, 2022 · 5 comments
Labels

Comments

@tangjianfang
Copy link

  • Error message
  • `ERROR:node_bindings.cc(146)] Fatal error in V8: v8_ArrayBuffer_NewBackingStore When the V8 Sandbox is enabled, ArrayBuffer backing stores must be allocated inside the sandbox address space. Please use an appropriate ArrayBuffer::Allocator to allocate these buffers.
  • Waiting for the debugger to disconnect...
  • error Command failed with exit code 3221225477.`
  • Crash dump information:'node-addon-api\napi-inl.h'
    image

  • Electron Official website information: https://www.electronjs.org/blog/v8-memory-cage
    Electron 21 and later will have the V8 Memory Cage enabled, with implications for some native modules.

When will a node-addon-api compatible version of electron 21 or later be released?

@NickNaso
Copy link
Member

NickNaso commented Nov 2, 2022

Hi @tangjianfang,
thanks for reporting this. We are already working on this issue nodejs/abi-stable-node#441 and now we have a PR to fix the crash on Electron 21 or later or in gerneral with all runtime that have the V8 memory cage enabled. See: nodejs/node#45181.

@tangjianfang
Copy link
Author

@NickNaso Thank you very much.

@Bartel-C8
Copy link

nodejs/node#45181 This has landed.

Any idea when it will be merged and a new release could be created? Thanks!

@mhdawson
Copy link
Member

@Bartel-C8 it is only going to help once Electron pulls in the updated code, versus new Node.js versions. The PR will be backported in line with the Node.js release schedule but also requires Electron updates.

@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants