Skip to content

Conversation

@rajeevmv
Copy link
Owner

@rajeevmv rajeevmv commented Sep 2, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

idear1203 and others added 30 commits July 21, 2020 17:27
* [Synapse] - Update Operations.json

* Update default response

* Update Example to fix validation error

Co-authored-by: Dongwei Wang <[email protected]>
* Adding a copy of security contact for new version

* update swagger with new SecurityContact API version

* Fix descriptions

* CR fixes

* compilation fix

* Update readme.md

Co-authored-by: ariklin <[email protected]>
* WIP: Updating Microsoft.AzureData

* Minor changes

* Adding new SystemData property to examples

* Fixed formatting

* Update azuredata.json

Fixed systemData.

* Update azuredata.json

Fixed identitytype case.

* Fixed formatting

* Removing changes from this PR (suggested by ARM). Will send a different PR to rename properties.
…ervices 2020 05 15 preview (#10133)

* integrate 05-01 into 05-15

* Updates readme

* Adding osType and vmImage parameters (#9519)

* update (#9713) (#9723)

Co-authored-by: Yingying Song <[email protected]>

Co-authored-by: syy0129 <[email protected]>
Co-authored-by: Yingying Song <[email protected]>

* add enableNodePublicIp to AMLCompute (#9725)

* Adding estimatedVMPrices to AML ListVMSzies (#9972)

Co-authored-by: Sriram Kakara <[email protected]>

* Changing description for nodeIdleTimeBeforeScaleDown

* Integrating delete changes

Co-authored-by: syy0129 <[email protected]>
Co-authored-by: Yingying Song <[email protected]>
Co-authored-by: comacgin <[email protected]>
Co-authored-by: sriramkakara <[email protected]>
Co-authored-by: Sriram Kakara <[email protected]>
For stable/v3.0/TextAnalytics.json, added text as a required property in sentenceSentiment.
Co-authored-by: Sanjai Ganesh <[email protected]>
Co-authored-by: Kalyan C Kesireddy <[email protected]>
Updated Managed resource group to be non-readonly

Co-authored-by: Amogh Natu <[email protected]>
* Update sample for readme.go.md

* Update
* Authenticate to AppInsights API

For just the data plane Direct path (v1 version), update the swagger definition to specify authentication against the API, instead of azure auth.

* Explicitly specify 'resource' in authorizationUrl
…stable/2019-08-01 (#9979)

* recos

* Remove system id

* spellcheck

* dataSource

* Rename category to control

* remove provider, add couple of other fields

* productName/compnent

* Inherit from resource, update example

* Prettier

Co-authored-by: Liran Chen <[email protected]>
* added swagger for 'actionplan/operation/attempts' , 'operationresults' endpoints and corrected Product Package Secrets endpoint

* updated the pfx file name type

* fix LintDiff erros

* added locations endpoint and fixed other changes

* added actionplans to custom-words.txt and uodated ProductSecret.json

* updated locations endpoint response

* updated the location parameter to global

* added 404 and default responses

* added locations endpoint - list operation

* removed 404 response for the 'ProductDeployment-remove operation'

* Adding  'productDeployments/executeRunner/action''

* removed 404 responses

* added default error responses and deleted 404 responses for file containers

* removed older version in the read.md 'input-file' section

* changed details info in the "ExtendedErrorInfo"

* changed ExtendedErrorInfo object

* updating error definition

* changing error definition in 2018-07-01 version

* updated location responses

* changed the entity name

* Revert "changed the entity name"

This reverts commit 2c7e079.

* Revert "updated location responses"

This reverts commit 78bca1d.

* updated locations Get response

* change for New-AzFileContainer command

* added Parameter for the New-AzsProductPackage

* changed productId to packageId

* updated operationId for Bootstrap

* changed operationId for deploy action

* changed paramters to object

* changed the operation Ids

* changed operationIds for the right command names

* execute runner changes

* fixed path parameter for secrets and remove command name

* changed the secret name

* changed secret parameters

* added changes to resolve conflicts

* changed version number

* changed the version number

* changed the tag name

* to fix conflicts

* added swagger for missing endpoints of the Deployment Resource Provider

fixed CI failures

* fix LintDiff erros

added locations endpoint and fixed other changes

added actionplans to custom-words.txt and uodated ProductSecret.json

updated locations endpoint response

* updated the location parameter to global

added 404 and default responses

added locations endpoint - list operation

removed 404 response for the 'ProductDeployment-remove operation'

Adding  'productDeployments/executeRunner/action''

removed 404 responses

added default error responses and deleted 404 responses for file containers

removed older version in the read.md 'input-file' section

changed details info in the "ExtendedErrorInfo"

changed ExtendedErrorInfo object

updating error definition

changing error definition in 2018-07-01 version

updated location responses

changed the entity name

Revert "changed the entity name"

This reverts commit 2c7e079.

Revert "updated location responses"

This reverts commit 78bca1d.

updated locations Get response

change for New-AzFileContainer command

added Parameter for the New-AzsProductPackage

changed productId to packageId

updated operationId for Bootstrap

changed operationId for deploy action

changed paramters to object

changed the operation Ids

changed operationIds for the right command names

execute runner changes

fixed path parameter for secrets and remove command name

changed the secret name

changed secret parameters

added changes to resolve conflicts

changed version number

changed the version number

changed the tag name

to fix conflicts

* added 204 responses for delete operation
…#10228)

* Removing ErrorResponse and OperationsListResult from livetoken_API.json, substituting with references to WebTestResults_API.json.

* Fix attempt.

* Typo fix

* Reverting.

* Adjust "Operation" name for uniqueness.
* Initial commit from previous API version

* updated to 2020-02-01

* update snapshot example

* Validation issues fixes

* Fix missing example volumeReplicationStatusGet

* Fix missing result example Account Update

* Fix missing Account Update op

* Fix missing Account Update result code

* Fix missing Account Update syntax

* Fix underscore

* Fix example

* Fix Readme

* Updated API version in examples

* ran prettier

* Prettier examples

* Trigger automation pipeline

* Rervert volue replicationStatus methods change

* Rervert volue replicationStatus methods change

* prettier

* Added Repo Azure sdk for trenton again

* Added trenton metadata

Co-authored-by: Audunn Baldvinsson <[email protected]>
* fix the error in api v3.1-preview.1

* update version

* fix newline
SearchIndexerDataSource dataChangeDetectionPolicy & dataDeletionDetectionPolicy
IndexingParamters batchSize, maxFailedItems & maxFailedItemsPerBatch
FieldMapping mappingFunction
SearchIndexer schedule, parameters & disabled
IndexerExecutionResult endTime
TextTranslationSkill suggestedFrom
* Add a new api and add 2020-02-02-preview versions

* Fix get and list example files.

* Remove 2019 api version from composite and update examples to 2020 api version.

* Create a new AzureADOnlyAuthentications api and remove enable\disable apis.

* update readme file.

* remove blank line and other azureADOnlyAuthentication parameter from aad admin api.

* Add missing curly braces and parameters.

* fix typo

* Prettier fixes

* Fix more prettier issues.

Co-authored-by: Amol Agarwal <[email protected]>
tugupt and others added 28 commits August 28, 2020 14:45
… preview (#10490)

* Enabling Put calls for Enrollment Department and Billing Scope

* Symenatic fixes

* Fixed Swagger Validation Report Fixes - spell check

* Review Comments
* hybridcompute-create a stable version

* updated readme
…cation' (#10613)

* Add SubAssessment event source type and add more automations examples

* Change Location isReadOnlu to false

* Test

* Add new read/write location and add new type TrackedResourceLocation

* Minor

* minor

* prettier fixes

* Change variable name to TrackedResourceLocation

* Change type name TrackedResourceLocation to AzureTrackedResourceLocation

* Update automations example
* Add 2020-03 for policy by replicating from 2019-09

* Real update of 2020-03-01

* Fixed global paramters

* Fixed error response structure

* Add filter for built-in
…#10424)

* Added swagger spec of previous version

* New changes related to Export,BYOK and cmk are included in new version

* Fix for eror that occured due to jobSecretsType

* Made changes in operation and default and corresponding swagger fix

* Fixed errors occured in CI

* Merge conflict that occurred due to sdk automation merge are resolved

* Added swagger spec of previous version

* New changes related to Export,BYOK and cmk are included in new version

* Fix for eror that occured due to jobSecretsType

* Made changes in operation and default and corresponding swagger fix

* Fixed errors occured in CI

* Merge conflict that occurred due to sdk automation merge are resolved

* Spell check fix

* prettier fix

* Additional examples for reference and syntactic fix

* Python multi api support

* Indent LintDiff fix in readme

* Updated structure to old one and resolved comments

Co-authored-by: Dhawal Jain <[email protected]>
…review/2020-07-10-preview (#10626)

* Update KeyVaultProperties to reflect array type

* Add Description

* Prettier
* Add ManagedInstanceAzureADOnlyAuthentications.

* Fix readme.md

* Fix validation and other lint errors.

* Resolve Lint errors.

* Remove 08 APIs.

* Remove location.
* Added rebill details for invoice

Added rebill details for invoice

* Fixed Prettier Check failures

Fixed Prettier Check failures

* Fixed model validation errors

Fixed model validation errors

* Fixed model validation error

Fixed model validation error

* Added readonly property to document type and rebill details

Added readonly property to document type and rebill details

* Updated examples

Updated examples

* Setting readonly property on rebillDetails

Setting readonly property on rebillDetails

* Fixed prettier-check error

Fixed prettier-check error

Co-authored-by: Anirban Sarkar <[email protected]>
* run multiapi

* Update script to output schema input files to readme.azureresourceschema.md

* Update readme.azureresourceschema.md structure
…stable/2020-01-01 (#8805)

* Adding new stable alerts API version 2020-01-01.
This updated version contains new alert (return value) schema, and a new state: "resolved".

* Fixing: https://github.com/Azure/oav/blob/master/documentation/oav-errors-reference.md#OBJECT_ADDITIONAL_PROPERTIES on "ResourceIdentifier" and "extendedProperties" definition

* Ran prettier-fix

* Changing "severity" enum name so it won't conflict with assessmentMetadata enum

* Changing "status" enum name to "alertStatus" so it won't conflict with other enums

* Microsoft Security 2020-01-01/alerts.json Change reactivate to activate

* Update readme.md

* remove additional properties

* update readme

* CR fixes

* Change description of ResourceIdentifiers property

* remove OData support

Co-authored-by: Nitsan Bracha <[email protected]>
Co-authored-by: Yifat Birnbaum <[email protected]>
* Update certificates.json

* Update keyvault.json

* Update specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.0/keyvault.json

Co-authored-by: Heath Stewart <[email protected]>

* Update specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.1/certificates.json

Co-authored-by: Heath Stewart <[email protected]>

Co-authored-by: Heath Stewart <[email protected]>
* Add startTime in DeploymentInstance definition

* add samples

* update preview version
* Revert "Update all readme.azureresourceschema.md (#10647)"

This reverts commit a615f5c.

* Update script to output schema input files to readme.azureresourceschema.md

* Update script to create apiVersion specific tags for schema generation

* Regenerating all readme.azureresourceschema.md

* Run npm run multiapi to update all-api-versions blocks
* Adding 7.2-preview version (#8397)

* Adding 7.2-preview version

Signed-off-by: vasanthrajams <[email protected]>

* Resolve PR feedback

* Fix output-folder for go code generation

Co-authored-by: Heath Stewart <[email protected]>

* Change the number of certificates user provides for security domain

This change modifies the number of certificates(containing public keys)
customer needs to provide for encrypting the security domain to a
M of N model. In this model, customer specifies the M certificates out
of N certificates needed to restore the security domain.

Signed-off-by: vasanthrajams <[email protected]>

* prettier check

* remove readyonly

* Security domain object specification

Signed-off-by: vasanthrajams <[email protected]>

* internal review

* prettier fix

* model validation fixes

* model validation

* security domain id

* Removing Security Domain ID

* Fixed a few more specs

* model validation failures

* pretty check

* changed tag

* tag change

Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: vasanthrajams <[email protected]>
…0665)

* Fix typo in 2020-03-13 API version

* fix casing and typo in 2020-08 API versions

* Re-add capitalizations where appropriate

Co-authored-by: Arvind Krishnaa Jagannathan <[email protected]>
…table/2020-08-01 (#10619)

* Adds base for updating Microsoft.Devices from version stable/2020-06-15 to version 2020-08-01

* Updates readme

* Updates API version in new specs and examples

* Adding properties in import/export devices requests.

* Fixing code format.

* Fixing code format.
@rajeevmv rajeevmv merged commit f7708b4 into rajeevmv:master Sep 2, 2020
rajeevmv pushed a commit that referenced this pull request Sep 2, 2020
* aws connector in asc including API and examples - draft 1

* adding 'state' to the connector

* when deleting aws connector that is not exist, return 404

* Updating connector is in put

* aws connector status updated to enum

* deleting post option in aws connector

* aws connector adding state to the example files

* adding description to aws connector

* Renaming awsConnectors to connectors

* renaming example files to connector without aws

* aws dropped from the connector and adding connector type

* update examples of connector based in the new schema

* adding proxy to arc onboarding

* updating example files

* fixing typo

* fixing arc to hybridComputeAutoProvision

* update connectors.json (#1)

* fixing file structure

* updating examples

* fixing connectorType to authenticationType

* adding another block of properites

* making two parts in the connector settings

* updating required fields

* Adding permission list

* fixing error

* changing name object

* fixing permission name

* adding all service principal fields

* update documentation of app serivce secret

* creating examples

* location changed to region

* create example changed to createupdate

* moving account id insode the connection object

* remove name fields in hybrid compute

* Adding base for aws onboarding

* two put and update examples

* fixing examples based new body

* fixing connector name

* fixing aws connctor example

* fixing readme and link to example file

* adding correct example file

* fixin example extension

* fixing discriminator

* provisioningState is required prop

* fixing link in readme file

* fixing typo in connectorName

* fixing provisioningState

* fixin authenticationType to authenticationType

* removing readonly fields from examples

* fixing credential fields

* remove id from create

* run Prettier on the files

* running prettier

* create two different x-ms-enum

* update examples of connectors

* update readme file

* removing custom from secure score

* fifixng enum permission prop

* fixing extra space in readme

* Adding gcp connector

* adding gcp example

* update example of get list

* fixing name

* running prettier

* fixing errors of build

* removing null values from examples

* taking secureScore.json new file

* all secret fields marked as format password

* remove required fields

* Adding relavent required fields

* remove password format

* writeonly fields are returned with <empty> value

* fixing gcp connector fields

* fixing delete response

* fiximng examples to return empty string on writeonly fields

* fixing delete response in the example

* change structure of authentication

* fixing inheretence in aws

* fixing structure of cred in aws and gcp

* write only fields are empty strings in the response of the examples

* after Prettier check

* clarifing the documentation of two fields

* fixing documentation of region field in hybrid compute.

Co-authored-by: Ayman Jarrous <[email protected]>
Co-authored-by: adzamri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.