Skip to content

Conversation

@mbialecka
Copy link
Contributor

@mbialecka mbialecka commented Jul 21, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 21, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 0d9a0c3 with merge commit 5514e7cc51c9c3e1c9b71ba2df71b80fe2762fcf. SDK Automation 13.0.17.20200619.4
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

azure-sdk-for-js

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 0d9a0c3 with merge commit 5514e7cc51c9c3e1c9b71ba2df71b80fe2762fcf. SDK Automation 13.0.17.20200619.4
  • ⚠️@azure/arm-azurestackhci [View full logs
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/azureStackHCIClient.js → ./dist/arm-azurestackhci.js...
    [npmPack] created ./dist/arm-azurestackhci.js in 179ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 37.2kB dist/arm-azurestackhci.js              
    [npmPack] npm notice 12.5kB dist/arm-azurestackhci.min.js          
    [npmPack] npm notice 1.5kB  esm/azureStackHCIClient.js             
    [npmPack] npm notice 2.5kB  esm/azureStackHCIClientContext.js      
    [npmPack] npm notice 8.2kB  esm/operations/clusters.js             
    [npmPack] npm notice 601B   esm/models/clustersMappers.js          
    [npmPack] npm notice 345B   esm/models/index.js                    
    [npmPack] npm notice 409B   esm/operations/index.js                
    [npmPack] npm notice 13.7kB esm/models/mappers.js                  
    [npmPack] npm notice 1.5kB  esm/operations/operations.js           
    [npmPack] npm notice 493B   esm/models/operationsMappers.js        
    [npmPack] npm notice 1.9kB  esm/models/parameters.js               
    [npmPack] npm notice 991B   rollup.config.js                       
    [npmPack] npm notice 1.7kB  package.json                           
    [npmPack] npm notice 457B   tsconfig.json                          
    [npmPack] npm notice 81.1kB dist/arm-azurestackhci.js.map          
    [npmPack] npm notice 12.2kB dist/arm-azurestackhci.min.js.map      
    [npmPack] npm notice 648B   esm/azureStackHCIClient.d.ts.map       
    [npmPack] npm notice 742B   esm/azureStackHCIClient.js.map         
    [npmPack] npm notice 504B   esm/azureStackHCIClientContext.d.ts.map
    [npmPack] npm notice 1.4kB  esm/azureStackHCIClientContext.js.map  
    [npmPack] npm notice 3.6kB  esm/operations/clusters.d.ts.map       
    [npmPack] npm notice 5.1kB  esm/operations/clusters.js.map         
    [npmPack] npm notice 308B   esm/models/clustersMappers.d.ts.map    
    [npmPack] npm notice 321B   esm/models/clustersMappers.js.map      
    [npmPack] npm notice 5.2kB  esm/models/index.d.ts.map              
    [npmPack] npm notice 158B   esm/operations/index.d.ts.map          
    [npmPack] npm notice 126B   esm/models/index.js.map                
    [npmPack] npm notice 173B   esm/operations/index.js.map            
    [npmPack] npm notice 934B   esm/models/mappers.d.ts.map            
    [npmPack] npm notice 8.0kB  esm/models/mappers.js.map              
    [npmPack] npm notice 659B   esm/operations/operations.d.ts.map     
    [npmPack] npm notice 906B   esm/operations/operations.js.map       
    [npmPack] npm notice 238B   esm/models/operationsMappers.d.ts.map  
    [npmPack] npm notice 251B   esm/models/operationsMappers.js.map    
    [npmPack] npm notice 445B   esm/models/parameters.d.ts.map         
    [npmPack] npm notice 1.3kB  esm/models/parameters.js.map           
    [npmPack] npm notice 3.2kB  README.md                              
    [npmPack] npm notice 1.0kB  esm/azureStackHCIClient.d.ts           
    [npmPack] npm notice 1.5kB  src/azureStackHCIClient.ts             
    [npmPack] npm notice 794B   esm/azureStackHCIClientContext.d.ts    
    [npmPack] npm notice 2.3kB  src/azureStackHCIClientContext.ts      
    [npmPack] npm notice 8.8kB  esm/operations/clusters.d.ts           
    [npmPack] npm notice 16.9kB src/operations/clusters.ts             
    [npmPack] npm notice 291B   esm/models/clustersMappers.d.ts        
    [npmPack] npm notice 585B   src/models/clustersMappers.ts          
    [npmPack] npm notice 13.7kB esm/models/index.d.ts                  
    [npmPack] npm notice 93B    esm/operations/index.d.ts              
    [npmPack] npm notice 13.3kB src/models/index.ts                    
    [npmPack] npm notice 377B   src/operations/index.ts                
    [npmPack] npm notice 1.1kB  esm/models/mappers.d.ts                
    [npmPack] npm notice 11.0kB src/models/mappers.ts                  
    [npmPack] npm notice 1.1kB  esm/operations/operations.d.ts         
    [npmPack] npm notice 2.3kB  src/operations/operations.ts           
    [npmPack] npm notice 183B   esm/models/operationsMappers.d.ts      
    [npmPack] npm notice 461B   src/models/operationsMappers.ts        
    [npmPack] npm notice 480B   esm/models/parameters.d.ts             
    [npmPack] npm notice 1.8kB  src/models/parameters.ts               
    [npmPack] npm notice 1.1kB  LICENSE.txt                            
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          @azure/arm-azurestackhci                
    [npmPack] npm notice version:       1.0.0                                   
    [npmPack] npm notice filename:      azure-arm-azurestackhci-1.0.0.tgz       
    [npmPack] npm notice package size:  39.4 kB                                 
    [npmPack] npm notice unpacked size: 290.6 kB                                
    [npmPack] npm notice shasum:        8c8c96fe830233215121b825abbd892131137ac6
    [npmPack] npm notice integrity:     sha512-AcrR1bTkiecUh[...]Blyvta/ZUQCxg==
    [npmPack] npm notice total files:   59                                      
    [npmPack] npm notice 
    No file is changed.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

azure-sdk-for-net

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 0d9a0c3 with merge commit 5514e7cc51c9c3e1c9b71ba2df71b80fe2762fcf. SDK Automation 13.0.17.20200619.4
  • ⚠️azure-mgmt-azurestackhci [View full logs
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-azurestackhci
    [build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-azurestackhci
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-azurestackhci
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    No file is changed.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 21, 2020

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yungezz
Copy link
Member

yungezz commented Jul 22, 2020

hi @isra-fel could you pls help to review this change since it's for .NET SDK generation? thanks

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yungezz yungezz merged commit 116b155 into Azure:master Jul 23, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants