[Data Factory] Support newClusterLogDestination property and allow object type for folderpath property #10158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
|
The new version has a different type 'object' than the previous one 'string'. New: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5527:9 Old: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5527:9 |
|
The new version has a different type 'object' than the previous one 'string'. New: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5527:9 Old: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5527:9 |
|
The new version has a different type 'object' than the previous one 'string'. New: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5527:9 Old: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5527:9 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Jul 16, 2020
Contributor
|
Can one of the admins verify this patch? |
Contributor
Author
|
We want to support both object and string type for "folderpath" property and this is also the pattern for other properties we have. Could any reviewer help to unblock this gated check or let me know how can i get this unblocked? Thanks |
Member
@jackmagic313 could you please help provide your justification for this breaking change? Will this breaking change break any existing customer? |
Contributor
Author
Thanks @qianwens! Justification: This is actually a bug fix. ADF follows the same pattern (using object type for property to support expression like {"value": "@concat('test1','test2')", "type": "Expression"} and comment the real type in the description) for almost all properties in models but this one was set as string by mistake. We checked the telemetry data and the usage is pretty low for this property and the only breaking scenario would be using string type extension method after getting the model from API method, which could be easily fixed by cast the type to string from object |
Contributor
Author
@qianwens could you let me know anything i should do to proceed this? |
qianwens
approved these changes
Jul 23, 2020
qianwens
added
the
Approved-BreakingChange
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.