-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Adding AML Workspace ID Property #10073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
1041 - AddedPropertyInResponse |
The new version has a new property 'amlWorkspaceId' in response that was not found in the old version. New: Microsoft.Databricks/stable/2018-04-01/databricks.json#L837:7 Old: Microsoft.Databricks/stable/2018-04-01/databricks.json#L837:7 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
shafqatanwar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we already had this parameter? I guess it was missing form swagger, i assume?
Yes this was not exposed, but now we are suggesting to unlink via ARM template deployment and hence this parameter should be visible in ARM template reference. So adding in swagger |
|
As identified in the automated checks there are breaking changes, please follow Azure Breaking changes approval request form as defined @Breaking Change Process |
This change is not breaking change. The current property is already supported by our service and we are exposing it in swagger. This is an optional parameter which don't need to specify always. Let us know if we want to discuss further on this. |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.