Skip to content

Launch the routers and session servers through head-pinned command actors - #1988

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-19from
tom/refactor-miles/op13-36
Open

Launch the routers and session servers through head-pinned command actors#1988
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-19from
tom/refactor-miles/op13-36

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

gemini-code-assist Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy fzyzcjy mentioned this pull request Jul 30, 2026
Open
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from 6f14253 to d3241bc Compare August 3, 2026 23:43
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch 2 times, most recently from 58c719c to dee68a7 Compare August 4, 2026 00:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from 620376d to 0c7827b Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from dee68a7 to 09a362a Compare August 4, 2026 06:54
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from 0c7827b to d8062c2 Compare August 4, 2026 07:24
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from 09a362a to 624295b Compare August 4, 2026 07:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from d8062c2 to 5cd5bb6 Compare August 4, 2026 07:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from 624295b to dab6078 Compare August 4, 2026 07:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from 5cd5bb6 to d17a05e Compare August 6, 2026 03:47
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch 2 times, most recently from ed7a46c to b70af80 Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from 2c4b1ff to e46d60a Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from b70af80 to 9463cd4 Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from e46d60a to cc30933 Compare August 10, 2026 06:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch 3 times, most recently from ed4b3f5 to b8870ce Compare August 10, 2026 16:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from 3602865 to c74d04a Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from b8870ce to 458fddf Compare August 12, 2026 02:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from c74d04a to f3930d8 Compare August 12, 2026 09:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from 458fddf to 44c04f6 Compare August 12, 2026 09:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from f3930d8 to 65ff578 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from 44c04f6 to 5c60d2b Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from 65ff578 to cca330d Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from 5c60d2b to e1bb998 Compare August 12, 2026 14:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from cca330d to e8c9ed0 Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch 3 times, most recently from 8cb5db5 to cecdc14 Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from 2acd406 to 02b99e6 Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from cecdc14 to 990a8ff Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from 02b99e6 to ebb8667 Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch 2 times, most recently from 0fa2ec1 to f0d7e6b Compare August 14, 2026 04:45
This was referenced Aug 26, 2026
Open
Open
guapisolo
guapisolo approved these changes Aug 26, 2026
View reviewed changes

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR #1988 changes in stack context: #1988 drops the router/session actor handles; #2051/#2054 establish durable ownership, with teardown completed by #2059/#2112 before safe-merge checkpoint #2176. The repair remains present through checked tip #2649.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from f0d7e6b to c2f3272 Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from 18aa56b to af6ec31 Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from c2f3272 to bb296f6 Compare August 31, 2026 23:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from 88b7256 to da7d987 Compare September 1, 2026 10:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from bb296f6 to a7d3b9d Compare September 1, 2026 10:03
@fzyzcjy
Launch the routers and session servers through head-pinned command ac…
99f7e88 
…tors

The sgl/miles router and the session servers stop being subprocesses the
driver forks: the rendered command now runs inside a CommandActor pinned
to the head node, so their lifetime is bound to an actor the cluster can
see instead of a bare child process. The head pinning keeps every port
decision local — the existing availability checks and allocations stay
valid, and the ports stay forwardable.

create_head_worker_actor is the generic piece: a gpu-less worker takes
no placement-group bundle and schedules onto the head node. Readiness
switches from watching a child process to wait_tcp_ready, which treats
the actor's death as the launch failing, mirroring the babysitter
contract where the subprocess and the actor die together.
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-36 branch from a7d3b9d to 99f7e88 Compare September 1, 2026 10:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-19 branch from da7d987 to 4f22feb Compare September 1, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guapisolo guapisolo guapisolo approved these changes
@yueming-yuan yueming-yuan Awaiting requested review from yueming-yuan yueming-yuan is a code owner
@maocheng23 maocheng23 Awaiting requested review from maocheng23 maocheng23 is a code owner
@jybsuper jybsuper Awaiting requested review from jybsuper jybsuper is a code owner
@Zhichenzzz Zhichenzzz Awaiting requested review from Zhichenzzz Zhichenzzz is a code owner
@Shi-Dong Shi-Dong Awaiting requested review from Shi-Dong Shi-Dong is a code owner
@yushengsu-thu yushengsu-thu Awaiting requested review from yushengsu-thu
@Rockdu Rockdu Awaiting requested review from Rockdu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fzyzcjy @guapisolo